Browser Plugin: Update Guest WebContents Visibility on BrowserPlugin Visiblity Change.

content/renderer/browser_plugin/browser_plugin.cc

Index: content/renderer/browser_plugin/browser_plugin.cc
diff --git a/content/renderer/browser_plugin/browser_plugin.cc b/content/renderer/browser_plugin/browser_plugin.cc
index 6e720e0535a1a3923adaa6431871de3feeaa3951..ad00ed944faffea6d79049e2ccff1dfe439bfc6d 100644
--- a/content/renderer/browser_plugin/browser_plugin.cc
+++ b/content/renderer/browser_plugin/browser_plugin.cc
@@ -68,7 +68,8 @@ BrowserPlugin::BrowserPlugin(
       resize_pending_(false),
       navigate_src_sent_(false),
       process_id_(-1),
-      persist_storage_(false) {
+      persist_storage_(false),
+      visible_(true) {
   BrowserPluginManager::Get()->AddBrowserPlugin(instance_id, this);
   bindings_.reset(new BrowserPluginBindings(this));
 
@@ -648,6 +649,17 @@ void BrowserPlugin::updateFocus(bool focused) {
 }
 
 void BrowserPlugin::updateVisibility(bool visible) {
+  if (visible_ == visible)

[Charlie Reis, 2012/10/05 00:33:18]

Just confirming: we don't need to care if the embedder's WebContents was hidden
or shown here, right?

I thought there might have been a bug if you had a weird sequence of setting
visibility from both above and below, but that doesn't seem to be the case.  It
looks like it's safe for this visible_ flag to only track whether the
BrowserPlugin thinks its visible or shown, since this IPC message will only
affect the guest's WebContents if both |embedder_visible| and |visible| are
true.

(Maybe it's worth mentioning in browser_plugin.h that visible_ tracks only
whether the browser plugin is visible, regardless of the whole embedder
RenderView's visibility.)

+    return;
+
+  visible_ = visible;
+  if (!navigate_src_sent_)
+    return;
+
+  BrowserPluginManager::Get()->Send(new BrowserPluginHostMsg_SetVisibility(
+      render_view_->GetRoutingID(),
+      instance_id_,
+      visible));
 }
 
 bool BrowserPlugin::acceptsInputEvents() {