Browser Plugin: Update Guest WebContents Visibility on BrowserPlugin Visiblity Change.

content/renderer/browser_plugin/browser_plugin.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/browser_plugin/browser_plugin.h"
 
 #include "base/message_loop.h"
 #include "base/string_util.h"
 #if defined (OS_WIN)
 #include "base/sys_info.h"
@@ skipping 50 matching lines @@
     const WebPluginParams& params)
     : instance_id_(instance_id),
       render_view_(render_view),
       container_(NULL),
       damage_buffer_(NULL),
       sad_guest_(NULL),
       guest_crashed_(false),
       resize_pending_(false),
       navigate_src_sent_(false),
       process_id_(-1),
-      persist_storage_(false) {
+      persist_storage_(false),
+      visible_(true) {
   BrowserPluginManager::Get()->AddBrowserPlugin(instance_id, this);
   bindings_.reset(new BrowserPluginBindings(this));
 
   ParseAttributes(params);
 }
 
 BrowserPlugin::~BrowserPlugin() {
   if (damage_buffer_)
     FreeDamageBuffer();
   RemoveEventListeners();
@@ skipping 559 matching lines @@
 }
 
 void BrowserPlugin::updateFocus(bool focused) {
   BrowserPluginManager::Get()->Send(new BrowserPluginHostMsg_SetFocus(
       render_view_->GetRoutingID(),
       instance_id_,
       focused));
 }
 
 void BrowserPlugin::updateVisibility(bool visible) {
+  if (visible_ == visible)

[Charlie Reis, 2012/10/05 00:33:18]

Just confirming: we don't need to care if the embedder's WebContents was hidden
or shown here, right?

I thought there might have been a bug if you had a weird sequence of setting
visibility from both above and below, but that doesn't seem to be the case.  It
looks like it's safe for this visible_ flag to only track whether the
BrowserPlugin thinks its visible or shown, since this IPC message will only
affect the guest's WebContents if both |embedder_visible| and |visible| are
true.

(Maybe it's worth mentioning in browser_plugin.h that visible_ tracks only
whether the browser plugin is visible, regardless of the whole embedder
RenderView's visibility.)

+    return;
+
+  visible_ = visible;
+  if (!navigate_src_sent_)
+    return;
+
+  BrowserPluginManager::Get()->Send(new BrowserPluginHostMsg_SetVisibility(
+      render_view_->GetRoutingID(),
+      instance_id_,
+      visible));
 }
 
 bool BrowserPlugin::acceptsInputEvents() {
   return true;
 }
 
 bool BrowserPlugin::handleInputEvent(const WebKit::WebInputEvent& event,
                                      WebKit::WebCursorInfo& cursor_info) {
   if (guest_crashed_ || !navigate_src_sent_)
     return false;
@@ skipping 30 matching lines @@
                                                  void* notify_data) {
 }
 
 void BrowserPlugin::didFailLoadingFrameRequest(
     const WebKit::WebURL& url,
     void* notify_data,
     const WebKit::WebURLError& error) {
 }
 
 }  // namespace content