Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1106593002: [chrome/browser/se*-ss*] favor DCHECK_CURRENTLY_ON for better logs (Closed)

Created:
5 years, 8 months ago by anujsharma
Modified:
5 years, 7 months ago
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, rouslan+spellwatch_chromium.org, rlp+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, groby+spellwatch_chromium.org, kmadhusu+watch_chromium.org, Mostyn Bramley-Moore
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/se*-ss* BUG=466848 Committed: https://crrev.com/83968f9ee9f0293cc64bf9a20b5c7d8cbf33d71b Cr-Commit-Position: refs/heads/master@{#327443}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -100 lines) Patch
M chrome/browser/search/hotword_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/instant_io_context.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/search/suggestions/image_fetcher_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/search_provider_install_data.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/search_engines/search_provider_install_state_message_filter.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/service_process/service_process_control.cc View 13 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/sessions/base_session_service_delegate_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/session_data_deleter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/signin/signin_header_helper.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/signin/signin_names_io_thread.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc View 9 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_custom_dictionary.cc View 17 chunks +22 lines, -22 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc View 11 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/spellchecker/spellcheck_message_filter_mac.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_service.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ssl/ssl_client_auth_observer.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (4 generated)
anujsharma
vitalybuka@chromium.org: Please review changes in chrome/browser/service_process/ dmazzoni@chromium.org: Please review changes in chrome/browser/speech/ rsleevi@chromium.org: Please review ...
5 years, 8 months ago (2015-04-23 14:35:29 UTC) #2
Ryan Sleevi
Meh for added macros, but I guess that was my own grumping as smarter people ...
5 years, 8 months ago (2015-04-23 14:37:21 UTC) #3
marja
chrome/browser/sessions LGTM
5 years, 8 months ago (2015-04-23 14:37:51 UTC) #4
dmazzoni
lgtm for chrome/browser/speech
5 years, 8 months ago (2015-04-23 15:21:16 UTC) #5
groby-ooo-7-16
lgtm for c/b/spellchecker
5 years, 8 months ago (2015-04-23 17:16:29 UTC) #6
blundell
chrome/browser/signin lgtm
5 years, 8 months ago (2015-04-23 20:38:32 UTC) #7
Peter Kasting
LGTM
5 years, 8 months ago (2015-04-23 21:06:34 UTC) #8
Jered
lgtm
5 years, 8 months ago (2015-04-23 21:10:29 UTC) #9
anujsharma
Thanks Ryan, marja, dmazzoni, groby, blundell, Peter, Jered for lgtm.
5 years, 7 months ago (2015-04-28 05:22:59 UTC) #10
anujsharma
@Vitaly Could you please give a thumbs up for this CL. Thanks!!
5 years, 7 months ago (2015-04-28 05:23:47 UTC) #11
Vitaly Buka (NO REVIEWS)
lgtm
5 years, 7 months ago (2015-04-28 20:19:44 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1106593002/1
5 years, 7 months ago (2015-04-29 03:02:01 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1106593002/1
5 years, 7 months ago (2015-04-29 06:35:40 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 07:07:22 UTC) #18
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 07:08:23 UTC) #19
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/83968f9ee9f0293cc64bf9a20b5c7d8cbf33d71b
Cr-Commit-Position: refs/heads/master@{#327443}

Powered by Google App Engine
This is Rietveld 408576698