chrome/browser/search_engines/search_provider_install_state_message_filter.cc - Issue 1106593002: [chrome/browser/se*-ss*] favor DCHECK_CURRENTLY_ON for better logs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/search_engines/search_provider_install_state_message_filter.cc

Issue 1106593002: [chrome/browser/se*-ss*] favor DCHECK_CURRENTLY_ON for better logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/search_engines/search_provider_install_data.cc ('k') | chrome/browser/service_process/service_process_control.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/search_engines/search_provider_install_state_message_filter.cc

diff --git a/chrome/browser/search_engines/search_provider_install_state_message_filter.cc b/chrome/browser/search_engines/search_provider_install_state_message_filter.cc

index e4effe2d789ce6e5edf40ad44eed0e9117d2b5d1..ccd32f4dcb5690316e8b538772a645ea67829686 100644

--- a/chrome/browser/search_engines/search_provider_install_state_message_filter.cc

+++ b/chrome/browser/search_engines/search_provider_install_state_message_filter.cc

@@ -29,12 +29,12 @@ SearchProviderInstallStateMessageFilter(

weak_factory_(this) {

// This is initialized by RenderProcessHostImpl. Do not add any non-trivial

// initialization here. Instead do it lazily when required.

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

}

bool SearchProviderInstallStateMessageFilter::OnMessageReceived(

const IPC::Message& message) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

+ DCHECK_CURRENTLY_ON(BrowserThread::IO);

bool handled = true;

IPC_BEGIN_MESSAGE_MAP(SearchProviderInstallStateMessageFilter, message)

IPC_MESSAGE_HANDLER_DELAY_REPLY(

@@ -47,7 +47,7 @@ bool SearchProviderInstallStateMessageFilter::OnMessageReceived(

SearchProviderInstallStateMessageFilter::

~SearchProviderInstallStateMessageFilter() {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

+ DCHECK_CURRENTLY_ON(BrowserThread::IO);

}

search_provider::InstallState