Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: chrome/browser/ui/app_list/app_list_service_views.cc

Issue 1106453002: Fixed app launcher crashing trying to load guest profile. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Windows compile. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_list/app_list_service_views.cc
diff --git a/chrome/browser/ui/app_list/app_list_service_views.cc b/chrome/browser/ui/app_list/app_list_service_views.cc
index 7f1cd4aca03e00e357a1430c91991e6793fd55f4..c87c0aabb34bc56d815b98a15b4d496f32d6acf8 100644
--- a/chrome/browser/ui/app_list/app_list_service_views.cc
+++ b/chrome/browser/ui/app_list/app_list_service_views.cc
@@ -30,6 +30,12 @@ void AppListServiceViews::Init(Profile* initial_profile) {
}
void AppListServiceViews::ShowForProfile(Profile* requested_profile) {
+ // App list profiles should not be off-the-record. It is currently possible to
+ // get here in an off-the-record profile via the Web Store
+ // (http://crbug.com/416380).
+ // TODO(mgiuca): DCHECK that requested_profile->IsOffTheRecord() and
+ // requested_profile->IsGuestSession() are false, once that is resolved.
+
ShowForProfileInternal(requested_profile,
app_list::AppListModel::INVALID_STATE);
}
« no previous file with comments | « chrome/browser/ui/app_list/app_list_service_unittest.cc ('k') | chrome/browser/ui/views/app_list/win/app_list_service_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698