Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1085)

Unified Diff: chrome/browser/ui/views/app_list/win/app_list_service_win.cc

Issue 1106453002: Fixed app launcher crashing trying to load guest profile. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Windows compile. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/app_list/app_list_service_views.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/app_list/win/app_list_service_win.cc
diff --git a/chrome/browser/ui/views/app_list/win/app_list_service_win.cc b/chrome/browser/ui/views/app_list/win/app_list_service_win.cc
index 6c00856ce856d71fc63449d5647467c75841a56f..e08d0568470f24ece5db857b4798e06ec94333f9 100644
--- a/chrome/browser/ui/views/app_list/win/app_list_service_win.cc
+++ b/chrome/browser/ui/views/app_list/win/app_list_service_win.cc
@@ -271,6 +271,12 @@ void AppListServiceWin::ShowForProfile(Profile* requested_profile) {
}
void AppListServiceWin::OnLoadProfileForWarmup(Profile* initial_profile) {
+ // App list profiles should not be off-the-record. It is currently possible to
+ // get here in an off-the-record profile via the Web Store
+ // (http://crbug.com/416380).
+ // TODO(mgiuca): DCHECK that requested_profile->IsOffTheRecord() and
+ // requested_profile->IsGuestSession() are false, once that is resolved.
+
if (!IsWarmupNeeded())
return;
« no previous file with comments | « chrome/browser/ui/app_list/app_list_service_views.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698