gin/modules/console.cc - Issue 1106393002: gin: Use V8 Maybe APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gin/modules/console.cc

Issue 1106393002: gin: Use V8 Maybe APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@maybe-gin-converter

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gin/modules/console.cc

diff --git a/gin/modules/console.cc b/gin/modules/console.cc

index d172373f01df2a0a2d194bfbc866e65f17015087..75241df081a7acd1f95fc8e2a87165890f4966e3 100644

--- a/gin/modules/console.cc

+++ b/gin/modules/console.cc

@@ -43,7 +43,7 @@ v8::Local<v8::Value> Console::GetModule(v8::Isolate* isolate) {

.Build();

data->SetObjectTemplate(&g_wrapper_info, templ);

}

- return templ->NewInstance();

+ return templ->NewInstance(isolate->GetCurrentContext()).ToLocalChecked();

}

} // namespace gin

« no previous file with comments | « gin/interceptor_unittest.cc ('k') | gin/modules/module_registry.h » ('j') | no next file with comments »