gin/interceptor_unittest.cc - Issue 1106393002: gin: Use V8 Maybe APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gin/interceptor_unittest.cc

Issue 1106393002: gin: Use V8 Maybe APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@maybe-gin-converter

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gin/interceptor_unittest.cc

diff --git a/gin/interceptor_unittest.cc b/gin/interceptor_unittest.cc

index 01c6ba950c54bb35597b6215ed17d52fcc16617f..02fb10d235a7c9028790192d4e76d45696c10eb2 100644

--- a/gin/interceptor_unittest.cc

+++ b/gin/interceptor_unittest.cc

@@ -139,7 +139,7 @@ class InterceptorTest : public V8Test {

v8::Local<v8::String> source = StringToV8(isolate, script_source);

EXPECT_FALSE(source.IsEmpty());

- gin::TryCatch try_catch;

+ gin::TryCatch try_catch(isolate);

v8::Local<v8::Script> script = v8::Script::Compile(source);

EXPECT_FALSE(script.IsEmpty());

v8::Local<v8::Value> val = script->Run();

« no previous file with comments | « gin/dictionary.h ('k') | gin/modules/console.cc » ('j') | no next file with comments »