Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1106363002: Disable window_manager_apptests again... (Closed)

Created:
5 years, 7 months ago by msw
Modified:
5 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable window_manager_apptests again... I fixed local crashes in https://codereview.chromium.org/1107133002 The bot fails on gl_surface init, which I can't repro: http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Linux/builds/4898/steps/app_tests/logs/stdio [0427/144427:ERROR:gl_surface_x11.cc(98)] XOpenDisplay failed. [0427/144427:ERROR:gl_surface_x11.cc(62)] NativeViewGLSurfaceOSMesa::InitializeOneOff failed. [0427/144427:FATAL:gl_surface.cc(136)] Check failed: InitializeOneOffImplementation( impl, fallback_to_osmesa, gpu_service_logging, disable_gl_drawing). BUG=480040 TEST=Bot goes green again. TBR=sky@chromium.org Committed: https://crrev.com/63b2a20daf725ae044410d92a85a5fbebec27bea Cr-Commit-Position: refs/heads/master@{#327159}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M mojo/tools/data/apptests View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
msw
Hey Scott, please take a look as you have time; thanks.
5 years, 7 months ago (2015-04-27 22:23:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1106363002/1
5 years, 7 months ago (2015-04-27 22:24:10 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-27 22:35:29 UTC) #4
commit-bot: I haz the power
5 years, 7 months ago (2015-04-27 22:36:32 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/63b2a20daf725ae044410d92a85a5fbebec27bea
Cr-Commit-Position: refs/heads/master@{#327159}

Powered by Google App Engine
This is Rietveld 408576698