Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 1107133002: Fix native_viewport CommandLine; enable window_manager_apptests. (Closed)

Created:
5 years, 8 months ago by msw
Modified:
5 years, 8 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix native_viewport CommandLine; enable window_manager_apptests. Update the native_viewport CommandLine usage pattern. (codereview.chromium.org/1057603003 removed per-app args) Re-enable window_manager_apptests with test and headless flags. (our FYI waterfall: http://build.chromium.org/p/chromium.mojo/console) BUG=480040 TEST=Tests pass on the waterfall. R=sky@chromium.org TBR=jochen@chromium.org Committed: https://crrev.com/4795dc0ed1c25fafc1e35e34614e4294d3811754 Cr-Commit-Position: refs/heads/master@{#327139}

Patch Set 1 #

Patch Set 2 : Update native_viewport CommandLine use; enable window_manager_apptests. #

Patch Set 3 : Cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -25 lines) Patch
M components/native_viewport/main.cc View 1 2 2 chunks +2 lines, -18 lines 0 comments Download
M components/native_viewport/public/cpp/lib/args.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/tools/data/apptests View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
msw
Hey Scott, please take a look; thanks!
5 years, 8 months ago (2015-04-27 20:36:15 UTC) #1
sky
LGTM
5 years, 8 months ago (2015-04-27 21:06:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1107133002/40001
5 years, 8 months ago (2015-04-27 21:19:51 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/59354)
5 years, 8 months ago (2015-04-27 21:30:33 UTC) #6
msw
TBR'ing jochen@chromium.org for components/OWNERS
5 years, 8 months ago (2015-04-27 21:34:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1107133002/40001
5 years, 8 months ago (2015-04-27 21:34:53 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-27 21:39:22 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 21:40:55 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4795dc0ed1c25fafc1e35e34614e4294d3811754
Cr-Commit-Position: refs/heads/master@{#327139}

Powered by Google App Engine
This is Rietveld 408576698