Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 1106333002: Apply the same logic with one of ChromeResourceDispatcherHostDelegate (Closed)

Created:
5 years, 8 months ago by Jaekyun Seok (inactive)
Modified:
5 years, 7 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Apply the same logic with one of ChromeResourceDispatcherHostDelegate https://codereview.chromium.org/1056913008 modified codes to carry over a user gesture bit for all the non-main frame request types. The same logic should be applied to AwResourceDispatcherHostDelegate. BUG=478972 Committed: https://crrev.com/712427d9fc981a3778912386b7237116f89fa12b Cr-Commit-Position: refs/heads/master@{#327382}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Jaekyun Seok (inactive)
torne@ and benm@, please review this CL. This is a missing part of https://codereview.chromium.org/1056913008.
5 years, 8 months ago (2015-04-27 21:39:10 UTC) #2
Jaekyun Seok (inactive)
boliu@, please review this CL.
5 years, 7 months ago (2015-04-28 20:50:28 UTC) #4
boliu
lgtm
5 years, 7 months ago (2015-04-28 20:55:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1106333002/1
5 years, 7 months ago (2015-04-28 21:20:29 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-28 22:43:21 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 22:44:08 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/712427d9fc981a3778912386b7237116f89fa12b
Cr-Commit-Position: refs/heads/master@{#327382}

Powered by Google App Engine
This is Rietveld 408576698