Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1129)

Issue 1056913008: Carry over a user gesture bit for all the non-main frame request types (Closed)

Created:
5 years, 8 months ago by Jaekyun Seok (inactive)
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Carry over a user gesture bit for all the non-main frame request types Any non-main frame request type could be used to ping and redirect a navigation. So we should support a user gesture carryover bit for it. BUG=478972 Committed: https://crrev.com/0044897feca3e12b01ea0f50939b5a5eb33c6046 Cr-Commit-Position: refs/heads/master@{#326146}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Carry over user gesture bit for all non-main frame request types #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -5 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/InterceptNavigationDelegateTest.java View 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + chrome/test/data/navigation_interception/navigation_from_image_onload.html View 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
Jaekyun Seok (inactive)
mariakhomenko@ and jochen@, please review this CL.
5 years, 8 months ago (2015-04-21 01:35:48 UTC) #2
jochen (gone - plz use gerrit)
https://codereview.chromium.org/1056913008/diff/1/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc File chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc (right): https://codereview.chromium.org/1056913008/diff/1/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc#newcode375 chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc:375: } else if (resource_type == content::RESOURCE_TYPE_XHR || why not ...
5 years, 8 months ago (2015-04-21 09:44:54 UTC) #3
Jaekyun Seok (inactive)
On 2015/04/21 09:44:54, jochen wrote: > https://codereview.chromium.org/1056913008/diff/1/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc > File chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc > (right): > > https://codereview.chromium.org/1056913008/diff/1/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc#newcode375 ...
5 years, 8 months ago (2015-04-21 10:54:19 UTC) #4
Jaekyun Seok (inactive)
PTAL. https://codereview.chromium.org/1056913008/diff/1/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc File chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc (right): https://codereview.chromium.org/1056913008/diff/1/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc#newcode375 chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc:375: } else if (resource_type == content::RESOURCE_TYPE_XHR || On ...
5 years, 8 months ago (2015-04-21 11:03:37 UTC) #5
jochen (gone - plz use gerrit)
lgtm
5 years, 8 months ago (2015-04-21 11:11:35 UTC) #6
Maria
lgtm
5 years, 8 months ago (2015-04-21 18:03:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1056913008/20001
5 years, 8 months ago (2015-04-21 21:19:35 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-21 22:27:31 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 22:29:54 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0044897feca3e12b01ea0f50939b5a5eb33c6046
Cr-Commit-Position: refs/heads/master@{#326146}

Powered by Google App Engine
This is Rietveld 408576698