Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 1106043002: Cleanup redundant "virtual+override" in mockpeerconnection. (Closed)

Created:
5 years, 8 months ago by ncarter (slow)
Modified:
5 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@override_content2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override} to follow C++11 style in content/renderer/media. This CL has just two files which got some extra "while I'm in there" cleanup while doing mechanical fixups across the codebase. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. BUG=417463 Committed: https://crrev.com/af05b2a50818299ef27c8fc84fd2f65b37401329 Cr-Commit-Position: refs/heads/master@{#326972}

Patch Set 1 #

Patch Set 2 : Add second file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -47 lines) Patch
M content/renderer/media/mock_peer_connection_impl.h View 2 chunks +22 lines, -30 lines 0 comments Download
M content/renderer/media/rtc_data_channel_handler.h View 1 1 chunk +15 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ncarter (slow)
tommi: Please review! Thanks
5 years, 8 months ago (2015-04-24 19:52:17 UTC) #2
tommi (sloooow) - chröme
lgtm
5 years, 8 months ago (2015-04-25 15:28:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1106043002/20001
5 years, 8 months ago (2015-04-25 15:28:54 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-25 15:40:33 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-25 15:41:37 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/af05b2a50818299ef27c8fc84fd2f65b37401329
Cr-Commit-Position: refs/heads/master@{#326972}

Powered by Google App Engine
This is Rietveld 408576698