Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: content/renderer/media/rtc_data_channel_handler.h

Issue 1106043002: Cleanup redundant "virtual+override" in mockpeerconnection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@override_content2
Patch Set: Add second file. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/media/mock_peer_connection_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/rtc_data_channel_handler.h
diff --git a/content/renderer/media/rtc_data_channel_handler.h b/content/renderer/media/rtc_data_channel_handler.h
index 40cc19d8cc5cd11eac4b5348a082c6839e5cb155..c1ae1336a7af2402456f9905edf0cdd2b2cdadc4 100644
--- a/content/renderer/media/rtc_data_channel_handler.h
+++ b/content/renderer/media/rtc_data_channel_handler.h
@@ -37,26 +37,24 @@ class CONTENT_EXPORT RtcDataChannelHandler
RtcDataChannelHandler(
const scoped_refptr<base::SingleThreadTaskRunner>& main_thread,
webrtc::DataChannelInterface* channel);
- virtual ~RtcDataChannelHandler();
+ ~RtcDataChannelHandler() override;
// blink::WebRTCDataChannelHandler implementation.
- virtual void setClient(
+ void setClient(
blink::WebRTCDataChannelHandlerClient* client) override;
- virtual blink::WebString label() override;
- virtual bool isReliable() override;
- virtual bool ordered() const override;
- virtual unsigned short maxRetransmitTime() const override;
- virtual unsigned short maxRetransmits() const override;
- virtual blink::WebString protocol() const override;
- virtual bool negotiated() const override;
- virtual unsigned short id() const override;
- // TODO(bemasc): Mark |state()| as |override| once https://codereview.chromium.org/782843003/
- // lands in Blink and rolls into Chromium.
- virtual blink::WebRTCDataChannelHandlerClient::ReadyState state() const;
- virtual unsigned long bufferedAmount() override;
- virtual bool sendStringData(const blink::WebString& data) override;
- virtual bool sendRawData(const char* data, size_t length) override;
- virtual void close() override;
+ blink::WebString label() override;
+ bool isReliable() override;
+ bool ordered() const override;
+ unsigned short maxRetransmitTime() const override;
+ unsigned short maxRetransmits() const override;
+ blink::WebString protocol() const override;
+ bool negotiated() const override;
+ unsigned short id() const override;
+ blink::WebRTCDataChannelHandlerClient::ReadyState state() const override;
+ unsigned long bufferedAmount() override;
+ bool sendStringData(const blink::WebString& data) override;
+ bool sendRawData(const char* data, size_t length) override;
+ void close() override;
const scoped_refptr<webrtc::DataChannelInterface>& channel() const;
« no previous file with comments | « content/renderer/media/mock_peer_connection_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698