Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 1106013002: cc: Fix property tree position updates when rebuilding is skipped (Closed)

Created:
5 years, 8 months ago by ajuma
Modified:
5 years, 8 months ago
Reviewers:
Ian Vollick
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Fix property tree position updates when rebuilding is skipped The parent_offset currently stored at each transform tree node sometimes depends on the transform between some other node (which happens to correspond to node's owning layer's parent's transform node) and the node's parent. When this transform changes and the transform tree isn't rebuilt, the parent_offset becomes stale. This CL replaces parent_offset with source_offset, which is the portion of parent_offset that doesn't depend on a transform between tree nodes, and adds a source_node_id to each node so that the transform between nodes (when needed) can be recomputed when the transform tree is updated. BUG=480589 Committed: https://crrev.com/f09db896fac58260590729fbba5f285ba06b7cd3 Cr-Commit-Position: refs/heads/master@{#326894}

Patch Set 1 #

Patch Set 2 : Add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -32 lines) Patch
M cc/trees/layer_tree_host_common_unittest.cc View 1 1 chunk +37 lines, -0 lines 0 comments Download
M cc/trees/property_tree.h View 2 chunks +7 lines, -1 line 0 comments Download
M cc/trees/property_tree.cc View 4 chunks +13 lines, -5 lines 0 comments Download
M cc/trees/property_tree_builder.cc View 3 chunks +27 lines, -26 lines 0 comments Download
M cc/trees/property_tree_unittest.cc View 9 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ajuma
5 years, 8 months ago (2015-04-24 20:41:53 UTC) #2
Ian Vollick
On 2015/04/24 20:41:53, ajuma wrote: lgtm!
5 years, 8 months ago (2015-04-24 21:27:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1106013002/20001
5 years, 8 months ago (2015-04-24 21:50:16 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-24 21:55:41 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 21:56:50 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f09db896fac58260590729fbba5f285ba06b7cd3
Cr-Commit-Position: refs/heads/master@{#326894}

Powered by Google App Engine
This is Rietveld 408576698