Issue 11060014: Issue 5621. Fix for infinite cycle during incomplete switch parsing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11060014: Issue 5621. Fix for infinite cycle during incomplete switch parsing (Closed)

Created:
8 years, 2 months ago by scheglov

Modified:
8 years, 2 months ago

Reviewers:
danrubel, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 5621. Fix for infinite cycle during incomplete switch parsing http://code.google.com/p/dart/issues/detail?id=5621 So, now analyzis as you type updates problems in this file much faster. R=danrubel@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=13206

Patch Set 1 #

Total comments: 1

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -20 lines)			Patch
	M	compiler/java/com/google/dart/compiler/parser/DartParser.java	View		1 chunk	+3 lines, -0 lines	1 comment	Download
	M	editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/refactoring/ExtractMethodRefactoringTest.java	View		1 chunk	+0 lines, -20 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

8 years, 2 months ago (2012-10-17 18:26:04 UTC) #3

https://codereview.chromium.org/11060014/diff/1/compiler/java/com/google/dart...
File compiler/java/com/google/dart/compiler/parser/DartParser.java (right):

https://codereview.chromium.org/11060014/diff/1/compiler/java/com/google/dart...
compiler/java/com/google/dart/compiler/parser/DartParser.java:4860: if (peek(0)
!= Token.LBRACE) {
Shouldn't this generate an error message to indicate that a block was expected?
Otherwise it looks like this will accept the following without error:

  switch (e)
  if (c) { ... }

(I checked, and it does accept it.)

Expand Messages | Collapse Messages