Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 1105933002: Fix ApproximatelyEqual for transforms (Closed)

Created:
5 years, 8 months ago by Ian Vollick
Modified:
5 years, 8 months ago
Reviewers:
ajuma
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ApproximatelyEqual for transforms I subtly broke this in https://codereview.chromium.org/1071803003. Due to a cut and paste error, we were never updating |delta|. Consequently, I missed a regression due to my property trees skipping: I wasn't forcing a rebuild when contents scale or content bounds changed (and this was required). I've fixed that in this CL as well. BUG=471786 Committed: https://crrev.com/9a706e68a90749d54e336829ae759a56931ccf31 Cr-Commit-Position: refs/heads/master@{#326827}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M cc/layers/contents_scaling_layer.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_common.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Ian Vollick
5 years, 8 months ago (2015-04-24 17:22:06 UTC) #2
ajuma
lgtm
5 years, 8 months ago (2015-04-24 17:23:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1105933002/1
5 years, 8 months ago (2015-04-24 17:25:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 17:30:56 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 17:31:42 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9a706e68a90749d54e336829ae759a56931ccf31
Cr-Commit-Position: refs/heads/master@{#326827}

Powered by Google App Engine
This is Rietveld 408576698