Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1071803003: Update matrix distance metric to account for snapping. (Closed)

Created:
5 years, 8 months ago by Ian Vollick
Modified:
5 years, 8 months ago
Reviewers:
ajuma
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update matrix distance metric to account for snapping. We snap translation components in the compositor. If we have floating point error near a rounding boundary we may round the wrong direction. The new matrix error function is no longer general purpose, so I've moved it out of transform_util BUG=471786 Committed: https://crrev.com/a5d60fa900b826124b6dccc331d2ab0f093e97f4 Cr-Commit-Position: refs/heads/master@{#324487}

Patch Set 1 #

Patch Set 2 : grammar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -35 lines) Patch
M cc/trees/layer_tree_host_common.cc View 1 1 chunk +18 lines, -2 lines 0 comments Download
M ui/gfx/transform_util.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/gfx/transform_util.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M ui/gfx/transform_util_unittest.cc View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ian Vollick
5 years, 8 months ago (2015-04-09 15:11:53 UTC) #2
ajuma
lgtm
5 years, 8 months ago (2015-04-09 15:18:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1071803003/20001
5 years, 8 months ago (2015-04-09 18:37:21 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-09 19:42:39 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 19:44:33 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a5d60fa900b826124b6dccc331d2ab0f093e97f4
Cr-Commit-Position: refs/heads/master@{#324487}

Powered by Google App Engine
This is Rietveld 408576698