Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 110593003: Add onNewLockPixels, that returns rowbytes and relies on info in pixelref (Closed)

Created:
7 years ago by reed1
Modified:
6 years, 11 months ago
Reviewers:
hal.canary, scroggo
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add onNewLockPixels, that returns rowbytes and relies on info in pixelref This reverts commit 890a6ec633c1f54891104a072a8964b4c2c81af9. BUG= R=scroggo@google.com Committed: https://code.google.com/p/skia/source/detail?r=12883

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -119 lines) Patch
M include/core/SkBitmapDevice.h View 1 chunk +2 lines, -0 lines 0 comments Download
M include/core/SkMallocPixelRef.h View 1 2 3 4 5 6 7 2 chunks +4 lines, -6 lines 0 comments Download
M include/core/SkPixelRef.h View 1 2 3 4 5 6 7 4 chunks +55 lines, -18 lines 0 comments Download
M include/gpu/SkGrPixelRef.h View 1 2 3 4 1 chunk +3 lines, -4 lines 0 comments Download
M include/images/SkImageRef.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkBitmapDevice.cpp View 1 chunk +17 lines, -18 lines 0 comments Download
M src/core/SkMallocPixelRef.cpp View 1 2 3 4 5 6 7 4 chunks +9 lines, -7 lines 0 comments Download
M src/core/SkPixelRef.cpp View 1 2 3 4 5 6 7 6 chunks +55 lines, -24 lines 0 comments Download
M src/core/SkScaledImageCache.cpp View 1 2 3 4 5 6 4 chunks +12 lines, -11 lines 0 comments Download
M src/gpu/SkGrPixelRef.cpp View 1 2 3 4 5 6 1 chunk +10 lines, -6 lines 0 comments Download
M src/images/SkImageRef.cpp View 1 2 3 4 5 6 3 chunks +10 lines, -7 lines 0 comments Download
M src/lazy/SkCachingPixelRef.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/lazy/SkCachingPixelRef.cpp View 1 2 3 4 5 6 7 5 chunks +11 lines, -8 lines 0 comments Download
M src/lazy/SkDiscardablePixelRef.h View 1 2 3 4 5 6 7 2 chunks +5 lines, -1 line 0 comments Download
M src/lazy/SkDiscardablePixelRef.cpp View 1 2 3 4 5 6 7 2 chunks +15 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
reed1
7 years ago (2013-12-13 21:41:52 UTC) #1
scroggo
On 2013/12/13 21:41:52, reed1 wrote: lgtm
7 years ago (2013-12-13 21:47:46 UTC) #2
reed1
Committed patchset #8 manually as r12883 (presubmit successful).
6 years, 11 months ago (2014-01-03 16:22:57 UTC) #3
reed1
6 years, 11 months ago (2014-01-03 16:32:29 UTC) #4
Message was sent while issue was closed. 
A revert of this CL has been created in
https://codereview.chromium.org/119753009/ by reed@google.com.

The reason for reverting is: SkImageRef_ashmem doesn't compile.

Powered by Google App Engine
This is Rietveld 408576698