Issue 1105813002: Merge to XFA: Remove unused nParamNum values from JS method tables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1105813002: Merge to XFA: Remove unused nParamNum values from JS method tables. (Closed)

Created:
5 years, 8 months ago by Tom Sepez

Modified:
5 years, 8 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+646 lines, -189 lines)			Patch
M	fpdfsdk/include/javascript/JS_Define.h	View	6 chunks	+6 lines, -8 lines	0 comments	Download
M	fpdfsdk/include/javascript/resource.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	fpdfsdk/include/jsapi/fxjs_v8.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	fpdfsdk/src/javascript/Document.cpp	View	10 chunks	+104 lines, -94 lines	0 comments	Download
M	fpdfsdk/src/javascript/Field.cpp	View	1 chunk	+26 lines, -26 lines	0 comments	Download
M	fpdfsdk/src/javascript/PublicMethods.cpp	View	1 chunk	+22 lines, -22 lines	0 comments	Download
M	fpdfsdk/src/javascript/app.cpp	View	1 chunk	+21 lines, -21 lines	0 comments	Download
M	fpdfsdk/src/javascript/color.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	fpdfsdk/src/javascript/console.cpp	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	fpdfsdk/src/javascript/global.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	fpdfsdk/src/javascript/report.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	fpdfsdk/src/javascript/resource.cpp	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	fpdfsdk/src/javascript/util.cpp	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	fpdfsdk/src/jsapi/fxjs_v8.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
A	testing/resources/javascript/document_methods.in	View	1 chunk	+340 lines, -0 lines	0 comments	Download
A	testing/resources/javascript/document_methods_expected.txt	View	1 chunk	+103 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Tom Sepez

Committed patchset #1 (id:1) manually as e5350eff5c5cfe4d01686a4c787d764bde5dd23c (presubmit successful).

5 years, 8 months ago (2015-04-24 01:14:30 UTC) #2

Message was sent while issue was closed.

lgtm