Remove unused nParamNum values from JS method tables.

Remove unused nParamNum values from JS method tables.

The code to validate the number of parameters happens inside each particular
method, rather than prior to method dispatch. As such, there's no point in
having this number take up space in the table.

Add some test to cover at least some of the per-method validations, and
update error messages to be more useful.

[Tom Sepez, 2015-04-23 21:57:31]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2015-04-23 21:57:32]

Lei, for review.

[Lei Zhang, 2015-04-24 00:46:24]

lgtm

[Tom Sepez, 2015-04-24 00:53:18]

Landed at ef25d9995e494bd596ffea8fb8c09c2e48daa9a0 
(There was an error automatically updating this codereview page).

[Tom Sepez, 2015-04-24 17:36:52]

Lei, for review.  Some small details in the bug.

[Tom Sepez, 2015-04-24 17:37:28]

On 2015/04/24 17:36:52, Tom Sepez wrote:
> Lei, for review.  Some small details in the bug.

NM. Too many windows open.  Sorry, you already reviewed this one.

[brucedawson, 2015-05-01 17:16:36]

brucedawson@chromium.org changed reviewers:
+ brucedawson@chromium.org

[brucedawson, 2015-05-01 17:16:37]

https://codereview.chromium.org/1084183008/diff/60001/fpdfsdk/src/javascript/...
File fpdfsdk/src/javascript/Document.cpp (right):

https://codereview.chromium.org/1084183008/diff/60001/fpdfsdk/src/javascript/...
fpdfsdk/src/javascript/Document.cpp:639: CJS_Context* pContext =
(CJS_Context*)cc;
This newly added pContext variable now shadows two identical declarations and
initializations in two inner scopes of this function. Around line 686 and 724 of
this file.

There is no bug, but the variable shadowing adds some confusion and should
probably be corrected.

This was found by /analyze in build 163.

[Tom Sepez, 2015-05-01 17:19:27]

> There is no bug, but the variable shadowing adds some confusion and should
> probably be corrected.
> 
> This was found by /analyze in build 163.

Filed as https://code.google.com/p/pdfium/issues/detail?id=148