Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 11058003: No need to kClear_Mode a layer right after its created, as that will automatically (Closed)

Created:
8 years, 2 months ago by reed1
Modified:
8 years, 2 months ago
CC:
chromium-reviews, Ben Goodger (Google), Paweł Hajdan Jr., asanka, Randy Smith (Not in Mondays), rdsmith+dwatch_chromium.org, Alexei Svitkine (slow), tfarina
Visibility:
Public.

Description

No need to kClear_Mode a layer right after its created, as that will automatically be done by Skia (assuming kHasAlphaLayer_SaveFlag was set, which it is by default). Also, catch one more place where saveLayer(alpha) drawimage restore can be replaced with drawimage(alpha) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=160227

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -14 lines) Patch
M chrome/browser/download/download_util.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/download/download_item_view.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/infobars/translate_infobar_base.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/controls/button/text_button.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
reed1
8 years, 2 months ago (2012-10-03 21:17:22 UTC) #1
reed1
grrr, try-bot is not building against a recent-enough version to get the new API in ...
8 years, 2 months ago (2012-10-03 21:28:18 UTC) #2
tfarina
On Wed, Oct 3, 2012 at 6:28 PM, <reed@google.com> wrote: > grrr, try-bot is not ...
8 years, 2 months ago (2012-10-03 21:31:24 UTC) #3
reed1
On 2012/10/03 21:31:24, tfarina wrote: > On Wed, Oct 3, 2012 at 6:28 PM, <mailto:reed@google.com> ...
8 years, 2 months ago (2012-10-03 21:33:37 UTC) #4
tfarina
On 2012/10/03 21:33:37, reed1 wrote: > Yes, thanks. Something recent would be good (just has ...
8 years, 2 months ago (2012-10-03 21:39:44 UTC) #5
reed1
The aura failures are around Audio, and I think those are unrelated to this CL. ...
8 years, 2 months ago (2012-10-04 12:57:39 UTC) #6
Alexei Svitkine (slow)
Sorry, I'm OOO on Vacation until the last week of October, please find another reviewer.
8 years, 2 months ago (2012-10-04 16:06:32 UTC) #7
reed1
Ben, can you approve?
8 years, 2 months ago (2012-10-04 17:57:03 UTC) #8
Ben Goodger (Google)
8 years, 2 months ago (2012-10-04 20:28:22 UTC) #9
lgtm

Powered by Google App Engine
This is Rietveld 408576698