Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 1105783002: Fix flakiness in FileManager SuggestAppDialog test (Closed)

Created:
5 years, 8 months ago by tbarzic
Modified:
5 years, 8 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix flakiness in FileManager SuggestAppDialog test Yeah, I forgot to update test in the previous patch :/ https://chromium.googlesource.com/chromium/src/+/0c71fc50716dcf2fef839bde83ef09287c64202b (which changed the element to which show-spinner class was applied) BUG=479757 TEST=Run the test locally Committed: https://crrev.com/275e7a7a9acc2cd8ed471c66775f766d3d956515 Cr-Commit-Position: refs/heads/master@{#326801}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M ui/file_manager/integration_tests/file_manager/suggest_app_dialog.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
tbarzic
5 years, 8 months ago (2015-04-24 00:20:42 UTC) #2
yoshiki
lgtm. Thank you for doing this!
5 years, 8 months ago (2015-04-24 08:10:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1105783002/1
5 years, 8 months ago (2015-04-24 14:57:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 15:27:19 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 15:28:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/275e7a7a9acc2cd8ed471c66775f766d3d956515
Cr-Commit-Position: refs/heads/master@{#326801}

Powered by Google App Engine
This is Rietveld 408576698