Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Side by Side Diff: chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Issue 1105783002: Fix flakiness in FileManager SuggestAppDialog test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ui/file_manager/integration_tests/file_manager/suggest_app_dialog.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Browser test for basic Chrome OS file manager functionality: 5 // Browser test for basic Chrome OS file manager functionality:
6 // - The file list is updated when a file is added externally to the Downloads 6 // - The file list is updated when a file is added externally to the Downloads
7 // folder. 7 // folder.
8 // - Selecting a file and copy-pasting it with the keyboard copies the file. 8 // - Selecting a file and copy-pasting it with the keyboard copies the file.
9 // - Selecting a file and pressing delete deletes it. 9 // - Selecting a file and pressing delete deletes it.
10 10
(...skipping 1022 matching lines...) Expand 10 before | Expand all | Expand 10 after
1033 #define MAYBE_Traverse Traverse 1033 #define MAYBE_Traverse Traverse
1034 #endif 1034 #endif
1035 WRAPPED_INSTANTIATE_TEST_CASE_P( 1035 WRAPPED_INSTANTIATE_TEST_CASE_P(
1036 MAYBE_Traverse, 1036 MAYBE_Traverse,
1037 FileManagerBrowserTest, 1037 FileManagerBrowserTest,
1038 ::testing::Values(TestParameter(IN_GUEST_MODE, "traverseDownloads"), 1038 ::testing::Values(TestParameter(IN_GUEST_MODE, "traverseDownloads"),
1039 TestParameter(NOT_IN_GUEST_MODE, "traverseDownloads"), 1039 TestParameter(NOT_IN_GUEST_MODE, "traverseDownloads"),
1040 TestParameter(NOT_IN_GUEST_MODE, "traverseDrive"))); 1040 TestParameter(NOT_IN_GUEST_MODE, "traverseDrive")));
1041 1041
1042 // Slow tests are disabled on debug build. http://crbug.com/327719 1042 // Slow tests are disabled on debug build. http://crbug.com/327719
1043 // Disabled under MSAN, ASAN, and LSAN as well. http://crbug.com/479757. 1043 // Disabled under MSAN as well. http://crbug.com/468980.
1044 // Flakes often: http://crbug.com/479757 1044 #if !defined(NDEBUG) || defined(MEMORY_SANITIZER)
1045 #define MAYBE_SuggestAppDialog DISABLED_SuggestAppDialog
1046 #else
1047 #define MAYBE_SuggestAppDialog SuggestAppDialog
1048 #endif
1045 WRAPPED_INSTANTIATE_TEST_CASE_P( 1049 WRAPPED_INSTANTIATE_TEST_CASE_P(
1046 DISABLED_SuggestAppDialog, 1050 MAYBE_SuggestAppDialog,
1047 FileManagerBrowserTest, 1051 FileManagerBrowserTest,
1048 ::testing::Values(TestParameter(NOT_IN_GUEST_MODE, "suggestAppDialog"))); 1052 ::testing::Values(TestParameter(NOT_IN_GUEST_MODE, "suggestAppDialog")));
1049 1053
1050 // Slow tests are disabled on debug build. http://crbug.com/327719 1054 // Slow tests are disabled on debug build. http://crbug.com/327719
1051 // Disabled under MSAN as well. http://crbug.com/468980. 1055 // Disabled under MSAN as well. http://crbug.com/468980.
1052 #if !defined(NDEBUG) || defined(MEMORY_SANITIZER) 1056 #if !defined(NDEBUG) || defined(MEMORY_SANITIZER)
1053 #define MAYBE_ExecuteDefaultTaskOnDownloads \ 1057 #define MAYBE_ExecuteDefaultTaskOnDownloads \
1054 DISABLED_ExecuteDefaultTaskOnDownloads 1058 DISABLED_ExecuteDefaultTaskOnDownloads
1055 #else 1059 #else
1056 #define MAYBE_ExecuteDefaultTaskOnDownloads ExecuteDefaultTaskOnDownloads 1060 #define MAYBE_ExecuteDefaultTaskOnDownloads ExecuteDefaultTaskOnDownloads
(...skipping 484 matching lines...) Expand 10 before | Expand all | Expand 10 after
1541 StartTest(); 1545 StartTest();
1542 } 1546 }
1543 1547
1544 IN_PROC_BROWSER_TEST_F(VideoPlayerBrowserTest, OpenSingleVideoOnDrive) { 1548 IN_PROC_BROWSER_TEST_F(VideoPlayerBrowserTest, OpenSingleVideoOnDrive) {
1545 set_test_case_name("openSingleVideoOnDrive"); 1549 set_test_case_name("openSingleVideoOnDrive");
1546 StartTest(); 1550 StartTest();
1547 } 1551 }
1548 1552
1549 } // namespace 1553 } // namespace
1550 } // namespace file_manager 1554 } // namespace file_manager
OLDNEW
« no previous file with comments | « no previous file | ui/file_manager/integration_tests/file_manager/suggest_app_dialog.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698