Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1105643002: Devtools: Introduce WI.ExtensibleToolbar (Closed)

Created:
5 years, 8 months ago by sergeyv
Modified:
5 years, 8 months ago
Reviewers:
dgozman, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Devtools: Introduce WI.ExtensibleToolbar BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194396

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address comments #

Patch Set 3 : Move close button out of toolbar #

Total comments: 12

Patch Set 4 : Use common styles #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -99 lines) Patch
M Source/devtools/front_end/components/InspectorView.js View 1 2 3 3 chunks +18 lines, -28 lines 0 comments Download
M Source/devtools/front_end/inspectorStyle.css View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/main/Main.js View 1 2 2 chunks +1 line, -63 lines 0 comments Download
M Source/devtools/front_end/main/module.json View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M Source/devtools/front_end/screencast/module.json View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/settings/module.json View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ui/Toolbar.js View 1 2 1 chunk +79 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
sergeyv
5 years, 8 months ago (2015-04-23 13:00:15 UTC) #2
dgozman
https://codereview.chromium.org/1105643002/diff/1/Source/devtools/front_end/components/InspectorView.js File Source/devtools/front_end/components/InspectorView.js (right): https://codereview.chromium.org/1105643002/diff/1/Source/devtools/front_end/components/InspectorView.js#newcode118 Source/devtools/front_end/components/InspectorView.js:118: this._leftToolbar = new WebInspector.ExtensibleToolbar("toolbar-left"); Let's rename to "main-toolbar-left". https://codereview.chromium.org/1105643002/diff/1/Source/devtools/front_end/components/InspectorView.js#newcode127 ...
5 years, 8 months ago (2015-04-23 14:09:36 UTC) #4
sergeyv
https://codereview.chromium.org/1105643002/diff/1/Source/devtools/front_end/components/InspectorView.js File Source/devtools/front_end/components/InspectorView.js (right): https://codereview.chromium.org/1105643002/diff/1/Source/devtools/front_end/components/InspectorView.js#newcode118 Source/devtools/front_end/components/InspectorView.js:118: this._leftToolbar = new WebInspector.ExtensibleToolbar("toolbar-left"); On 2015/04/23 14:09:36, dgozman wrote: ...
5 years, 8 months ago (2015-04-23 17:42:12 UTC) #5
dgozman
lgtm modulo comments https://codereview.chromium.org/1105643002/diff/40001/Source/devtools/front_end/components/InspectorView.js File Source/devtools/front_end/components/InspectorView.js (right): https://codereview.chromium.org/1105643002/diff/40001/Source/devtools/front_end/components/InspectorView.js#newcode119 Source/devtools/front_end/components/InspectorView.js:119: this._leftToolbar.element.classList.add("inspector-view-toolbar", "inspector-view-toolbar-left"); "inspector-view-toolbar" is unused. https://codereview.chromium.org/1105643002/diff/40001/Source/devtools/front_end/components/InspectorView.js#newcode123 ...
5 years, 8 months ago (2015-04-24 12:12:34 UTC) #6
sergeyv
https://codereview.chromium.org/1105643002/diff/40001/Source/devtools/front_end/components/InspectorView.js File Source/devtools/front_end/components/InspectorView.js (right): https://codereview.chromium.org/1105643002/diff/40001/Source/devtools/front_end/components/InspectorView.js#newcode119 Source/devtools/front_end/components/InspectorView.js:119: this._leftToolbar.element.classList.add("inspector-view-toolbar", "inspector-view-toolbar-left"); On 2015/04/24 12:12:34, dgozman wrote: > "inspector-view-toolbar" ...
5 years, 8 months ago (2015-04-24 12:25:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1105643002/60001
5 years, 8 months ago (2015-04-24 12:29:53 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 15:07:36 UTC) #11
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194396

Powered by Google App Engine
This is Rietveld 408576698