Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1304)

Unified Diff: Source/devtools/front_end/components/InspectorView.js

Issue 1105643002: Devtools: Introduce WI.ExtensibleToolbar (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Use common styles Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/devtools/front_end/inspectorStyle.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/components/InspectorView.js
diff --git a/Source/devtools/front_end/components/InspectorView.js b/Source/devtools/front_end/components/InspectorView.js
index 48fb5a248e674d7f4fc2bdd0b3071b2894bfdcca..dca54d7fe278dda06f0d7ab5f048a239d6ebc822 100644
--- a/Source/devtools/front_end/components/InspectorView.js
+++ b/Source/devtools/front_end/components/InspectorView.js
@@ -53,20 +53,6 @@ WebInspector.InspectorView = function()
this._drawerSplitView.setMainView(this._tabbedPane);
this._drawer = new WebInspector.Drawer(this._drawerSplitView);
- this._leftToolbar = new WebInspector.Toolbar();
- this._leftToolbar.element.classList.add("inspector-view-toolbar", "inspector-view-toolbar-left");
- this._leftToolbar.makeNarrow();
- this._tabbedPane.insertBeforeTabStrip(this._leftToolbar.element);
-
- this._rightToolbar = new WebInspector.Toolbar();
- this._rightToolbar.element.classList.add("inspector-view-toolbar");
- this._tabbedPane.appendAfterTabStrip(this._rightToolbar.element);
-
- this._closeButtonToolbarItem = createElementWithClass("div", "inspector-view-close-button");
- var closeButtonElement = this._closeButtonToolbarItem.createChild("div", "", "dt-close-button");
- closeButtonElement.addEventListener("click", InspectorFrontendHost.closeWindow.bind(InspectorFrontendHost), true);
- this._rightToolbar.element.appendChild(this._closeButtonToolbarItem);
-
this._panels = {};
// Used by tests.
WebInspector["panels"] = this._panels;
@@ -127,20 +113,22 @@ WebInspector.InspectorView.prototype = {
WebInspector.endBatchUpdate();
},
- /**
- * @param {!WebInspector.ToolbarItem} item
- */
- appendToLeftToolbar: function(item)
+ createToolbars: function()
{
- this._leftToolbar.appendToolbarItem(item);
- },
+ this._leftToolbar = new WebInspector.ExtensibleToolbar("main-toolbar-left");
+ this._leftToolbar.element.classList.add("inspector-view-toolbar", "inspector-view-toolbar-left");
+ this._leftToolbar.makeNarrow();
+ this._tabbedPane.insertBeforeTabStrip(this._leftToolbar.element);
- /**
- * @param {!WebInspector.ToolbarItem} item
- */
- appendToRightToolbar: function(item)
- {
- this._rightToolbar.appendToolbarItem(item);
+ var rightToolbarContainer = createElementWithClass("div", "hbox flex-none flex-centered");
+ this._tabbedPane.appendAfterTabStrip(rightToolbarContainer);
+
+ this._rightToolbar = new WebInspector.ExtensibleToolbar("main-toolbar-right");
+ this._rightToolbar.element.classList.add("inspector-view-toolbar", "flex-none");
+ rightToolbarContainer.appendChild(this._rightToolbar.element);
+
+ var closeButtonElement = rightToolbarContainer.createChild("div", "inspector-view-close-button flex-none", "dt-close-button");
+ closeButtonElement.addEventListener("click", InspectorFrontendHost.closeWindow.bind(InspectorFrontendHost), true);
},
/**
@@ -204,8 +192,10 @@ WebInspector.InspectorView.prototype = {
{
this._currentPanelLocked = WebInspector.targetManager.allTargetsSuspended();
this._tabbedPane.setCurrentTabLocked(this._currentPanelLocked);
- this._leftToolbar.setEnabled(!this._currentPanelLocked);
- this._rightToolbar.setEnabled(!this._currentPanelLocked);
+ if (this._leftToolbar)
+ this._leftToolbar.setEnabled(!this._currentPanelLocked);
+ if (this._rightToolbar)
+ this._rightToolbar.setEnabled(!this._currentPanelLocked);
},
/**
« no previous file with comments | « no previous file | Source/devtools/front_end/inspectorStyle.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698