Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: components/bookmarks/browser/bookmark_model.h

Issue 1105413002: Avoid conversion of index to BookmarkNode pointer unnacessarily. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes as per review comments. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/bookmarks/browser/bookmark_model.h
diff --git a/components/bookmarks/browser/bookmark_model.h b/components/bookmarks/browser/bookmark_model.h
index 076b01b5c53b6c30c7f30afbda03d4952ee014f9..ecbdc74656ac1cd7631660af52ba57b9ed3d3518 100644
--- a/components/bookmarks/browser/bookmark_model.h
+++ b/components/bookmarks/browser/bookmark_model.h
@@ -127,9 +127,9 @@ class BookmarkModel : public KeyedService {
// state during their own initializer, such as the NTP.
bool IsDoingExtensiveChanges() const { return extensive_changes_ > 0; }
- // Removes the node at the given |index| from |parent|. Removing a folder node
- // recursively removes all nodes. Observers are notified immediately.
- void Remove(const BookmarkNode* parent, int index);
+ // Removes the child node. Removing a folder node recursively removes all
sky 2015/04/30 18:16:13 Removes |node| from the model and deletes it.
Deepak 2015/05/02 08:15:48 Done.
+ // nodes. Observers are notified immediately.
+ void Remove(const BookmarkNode* child);
sky 2015/04/30 18:16:13 child->node
Deepak 2015/05/02 08:15:48 Done.
// Removes all the non-permanent bookmark nodes that are editable by the user.
// Observers are only notified when all nodes have been removed. There is no

Powered by Google App Engine
This is Rietveld 408576698