components/bookmarks/browser/bookmark_index_unittest.cc - Issue 1105413002: Avoid conversion of index to BookmarkNode pointer unnacessarily.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bookmarks/browser/bookmark_index_unittest.cc

Issue 1105413002: Avoid conversion of index to BookmarkNode pointer unnacessarily. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes as per review comments. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/bookmarks/browser/bookmark_expanded_state_tracker_unittest.cc ('k') | components/bookmarks/browser/bookmark_model.h » ('j') | components/bookmarks/browser/bookmark_model.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/bookmarks/browser/bookmark_index_unittest.cc

diff --git a/components/bookmarks/browser/bookmark_index_unittest.cc b/components/bookmarks/browser/bookmark_index_unittest.cc

index 22efeaaa754a5a4bc5b4d61333b23f02b6a63b87..cab18e56987f86637307686fa8d73c3d1cc0b2e8 100644

--- a/components/bookmarks/browser/bookmark_index_unittest.cc

+++ b/components/bookmarks/browser/bookmark_index_unittest.cc

@@ -452,7 +452,7 @@ TEST_F(BookmarkIndexTest, Remove) {

AddBookmarks(titles, urls, arraysize(titles));

// Remove the node and make sure we don't get back any results.

- model_->Remove(model_->other_node(), 0);

+ model_->Remove(model_->other_node()->GetChild(0));

ExpectMatches("A", NULL, 0U);

}