components/bookmarks/browser/bookmark_expanded_state_tracker_unittest.cc - Issue 1105413002: Avoid conversion of index to BookmarkNode pointer unnacessarily.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bookmarks/browser/bookmark_expanded_state_tracker_unittest.cc

Issue 1105413002: Avoid conversion of index to BookmarkNode pointer unnacessarily. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes as per review comments. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc ('k') | components/bookmarks/browser/bookmark_index_unittest.cc » ('j') | components/bookmarks/browser/bookmark_model.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/bookmarks/browser/bookmark_expanded_state_tracker_unittest.cc

diff --git a/components/bookmarks/browser/bookmark_expanded_state_tracker_unittest.cc b/components/bookmarks/browser/bookmark_expanded_state_tracker_unittest.cc

index 379e4ec710d4651040d02c34f34de9ef116b5786..f8cefa928bc028b8b97c99741355b2b02bcbc008 100644

--- a/components/bookmarks/browser/bookmark_expanded_state_tracker_unittest.cc

+++ b/components/bookmarks/browser/bookmark_expanded_state_tracker_unittest.cc

@@ -88,7 +88,7 @@ TEST_F(BookmarkExpandedStateTrackerTest, SetExpandedNodes) {

EXPECT_EQ(nodes, tracker->GetExpandedNodes());

// Remove the folder, which should remove it from the list of expanded nodes.

- model_->Remove(model_->bookmark_bar_node(), 0);

+ model_->Remove(model_->bookmark_bar_node()->GetChild(0));

nodes.erase(n1);

n1 = NULL;

EXPECT_EQ(nodes, tracker->GetExpandedNodes());