Issue 11054025: [Sync] Add HTTP status codes to NavigationEntry and TabNavigation

Issue 11054025: [Sync] Add HTTP status codes to NavigationEntry and TabNavigation (Closed)

Created:
8 years, 2 months ago by akalin

Modified:
7 years, 9 months ago

Reviewers:
Nicolas Zea, sky

CC:
chromium-reviews, akalin, Raghu Simha, jam, joi+watch-content_chromium.org, marja+watch_chromium.org, darin-cc_chromium.org, haitaol1, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Sync] Add HTTP status codes to NavigationEntry and TabNavigation Also pickle and sync the status codes. BUG=153936

Patch Set 3 : Rebase onto 11096037 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+158 lines, -11 lines)			Patch
M	chrome/browser/sessions/session_restore_browsertest.cc	View	1 2	4 chunks	+7 lines, -4 lines	0 comments	Download
M	chrome/browser/sessions/session_types.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/sessions/session_types.cc	View		8 chunks	+11 lines, -1 line	0 comments	Download
M	chrome/browser/sessions/session_types_test_helper.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/sessions/session_types_test_helper.cc	View	1 2	2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/sessions/session_types_unittest.cc	View	1 2	9 chunks	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/sessions/tab_restore_service_browsertest.cc	View	1 2	1 chunk	+47 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/glue/session_model_associator_unittest.cc	View	1 2	2 chunks	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc	View	1 2	1 chunk	+28 lines, -0 lines	0 comments	Download
M	content/browser/renderer_host/test_render_view_host.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/web_contents/navigation_controller_impl.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/web_contents/navigation_controller_impl_unittest.cc	View	1	2 chunks	+4 lines, -1 line	0 comments	Download
M	content/browser/web_contents/navigation_entry_impl.h	View	1	3 chunks	+5 lines, -3 lines	0 comments	Download
M	content/browser/web_contents/navigation_entry_impl.cc	View		3 chunks	+10 lines, -0 lines	0 comments	Download
M	content/public/browser/navigation_entry.h	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	sync/protocol/session_specifics.proto	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM https://codereview.chromium.org/11054025/diff/1/chrome/browser/sessions/session_types.cc File chrome/browser/sessions/session_types.cc (right): https://codereview.chromium.org/11054025/diff/1/chrome/browser/sessions/session_types.cc#newcode308 chrome/browser/sessions/session_types.cc:308: http_status_code_ = 0; You don't really need this ...

8 years, 2 months ago (2012-10-04 15:56:22 UTC) #3

Nicolas Zea

8 years, 2 months ago (2012-10-04 18:41:30 UTC) #4

https://codereview.chromium.org/11054025/diff/1/chrome/browser/sync/test/inte...
File chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc
(right):

https://codereview.chromium.org/11054025/diff/1/chrome/browser/sync/test/inte...
chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc:120:
EXPECT_EQ(200, SessionTypesTestHelper::GetHttpStatusCode(*it3));
verify this navigation is for the proper url as well?

https://codereview.chromium.org/11054025/diff/1/sync/protocol/session_specifi...
File sync/protocol/session_specifics.proto (right):

https://codereview.chromium.org/11054025/diff/1/sync/protocol/session_specifi...
sync/protocol/session_specifics.proto:127: // The status code from the last
navigation.
Is it the response code of the last successful navigation, or this particular
navigation? It seemed like if this navigation failed, this might be a non-200
value (e.g. a 404, 0, etc).

Expand Messages | Collapse Messages