sync/protocol/session_specifics.proto - Issue 11054025: [Sync] Add HTTP status codes to NavigationEntry and TabNavigation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sync/protocol/session_specifics.proto

Issue 11054025: [Sync] Add HTTP status codes to NavigationEntry and TabNavigation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc ('K') | « content/public/browser/navigation_entry.h ('k') | no next file » | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4 //	4 //

5 // Sync protocol datatype extension for sessions.	5 // Sync protocol datatype extension for sessions.

6	6

7 // Update proto_value_conversions{.h,.cc,_unittest.cc} if you change	7 // Update proto_value_conversions{.h,.cc,_unittest.cc} if you change

8 // any fields in this file.	8 // any fields in this file.

9	9

10 syntax = "proto2";	10 syntax = "proto2";

(...skipping 106 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
117 // User used the Forward or Back button to navigate among browsing history.	117 // User used the Forward or Back button to navigate among browsing history.

118 optional bool navigation_forward_back = 10;	118 optional bool navigation_forward_back = 10;

119 // User used the address bar to trigger this navigation.	119 // User used the address bar to trigger this navigation.

120 optional bool navigation_from_address_bar = 11;	120 optional bool navigation_from_address_bar = 11;

121 // User is navigating to the home page.	121 // User is navigating to the home page.

122 optional bool navigation_home_page = 12;	122 optional bool navigation_home_page = 12;

123 // The beginning of a navigation chain.	123 // The beginning of a navigation chain.

124 optional bool navigation_chain_start = 13;	124 optional bool navigation_chain_start = 13;

125 // The last transition in a redirect chain.	125 // The last transition in a redirect chain.

126 optional bool navigation_chain_end = 14;	126 optional bool navigation_chain_end = 14;

	127 // The status code from the last navigation.
	Nicolas Zea 2012/10/04 18:41:31 Is it the response code of the last successful nav Is it the response code of the last successful navigation, or this particular navigation? It seemed like if this navigation failed, this might be a non-200 value (e.g. a 404, 0, etc).
	128 optional int32 http_status_code = 15;

127 }	129 }

128

OLD	NEW