Issue 1105363003: [turbofan] Don't spread global flag checks all over the compiler code.

Issue 1105363003: [turbofan] Don't spread global flag checks all over the compiler code. (Closed)

Created:
5 years, 7 months ago by Benedikt Meurer

Modified:
5 years, 7 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[turbofan] Don't spread global flag checks all over the compiler code. Better encapsulate the source position handling in TurboFan. R=svenpanne@chromium.org Committed: https://crrev.com/b9d583d581453322251ae4b736bd88348b03316a Cr-Commit-Position: refs/heads/master@{#28153}

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+73 lines, -54 lines)			Patch
M	src/compiler.h	View	2 chunks	+8 lines, -1 line	0 comments	Download
M	src/compiler.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/compiler/instruction-selector.h	View	2 chunks	+9 lines, -4 lines	0 comments	Download
M	src/compiler/instruction-selector.cc	View	2 chunks	+8 lines, -7 lines	0 comments	Download
M	src/compiler/pipeline.cc	View	7 chunks	+27 lines, -22 lines	0 comments	Download
M	src/compiler/simplified-lowering.cc	View	1 chunk	+3 lines, -7 lines	0 comments	Download
M	src/compiler/source-position.h	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	src/compiler/source-position.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	test/unittests/compiler/instruction-selector-unittest.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	test/unittests/compiler/instruction-selector-unittest.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download

Total messages: 7 (1 generated)

Benedikt Meurer

Hey Sven, We should not spread tests with FLAG_turbo_source_positions all over the code. Simple cleanup. ...

5 years, 7 months ago (2015-04-30 09:12:45 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1105363003/1

5 years, 7 months ago (2015-04-30 09:25:38 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-04-30 09:56:42 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/b9d583d581453322251ae4b736bd88348b03316a
Cr-Commit-Position: refs/heads/master@{#28153}