Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: src/compiler/instruction-selector.cc

Issue 1105363003: [turbofan] Don't spread global flag checks all over the compiler code. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/instruction-selector.h ('k') | src/compiler/pipeline.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/instruction-selector.cc
diff --git a/src/compiler/instruction-selector.cc b/src/compiler/instruction-selector.cc
index ed44ade1027dd52dee6b8e7451dd7778253cdd2f..ff162e9c77b531c783945a555c2045a049367a19 100644
--- a/src/compiler/instruction-selector.cc
+++ b/src/compiler/instruction-selector.cc
@@ -18,16 +18,16 @@ namespace v8 {
namespace internal {
namespace compiler {
-InstructionSelector::InstructionSelector(Zone* zone, size_t node_count,
- Linkage* linkage,
- InstructionSequence* sequence,
- Schedule* schedule,
- SourcePositionTable* source_positions,
- Features features)
+InstructionSelector::InstructionSelector(
+ Zone* zone, size_t node_count, Linkage* linkage,
+ InstructionSequence* sequence, Schedule* schedule,
+ SourcePositionTable* source_positions,
+ SourcePositionMode source_position_mode, Features features)
: zone_(zone),
linkage_(linkage),
sequence_(sequence),
source_positions_(source_positions),
+ source_position_mode_(source_position_mode),
features_(features),
schedule_(schedule),
current_block_(NULL),
@@ -426,7 +426,8 @@ void InstructionSelector::VisitBlock(BasicBlock* block) {
SourcePosition source_position = source_positions_->GetSourcePosition(node);
if (source_position.IsUnknown()) continue;
DCHECK(!source_position.IsInvalid());
- if (FLAG_turbo_source_positions || node->opcode() == IrOpcode::kCall) {
+ if (source_position_mode_ == kAllSourcePositions ||
+ node->opcode() == IrOpcode::kCall) {
sequence()->SetSourcePosition(instructions_[current_node_end],
source_position);
}
« no previous file with comments | « src/compiler/instruction-selector.h ('k') | src/compiler/pipeline.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698