Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 1105333002: Introduce printers for Node and Position for ease of developing GTest test files (Closed)

Created:
5 years, 8 months ago by yosin_UTC9
Modified:
5 years, 7 months ago
Reviewers:
tkent
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Introduce printers for Node and Position for ease of developing GTest test files This patch introduces printers of Node and Position classes to use with GTest for improving productivity of writing tests using GTest. This patch is result of collaboration work with hajimehoshi@chromium.org for selection of web components. After this patch, we are going to implement another strategies for the composed tree. We've already prepared that at http://crrev.com/1009603011. BUG=275851 TEST=n/a; No behavior changes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195682

Patch Set 1 #

Total comments: 2

Patch Set 2 : 2015-05-20T13:40:11 #

Total comments: 2

Patch Set 3 : 2015-05-21T15:05:46 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -0 lines) Patch
M Source/core/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/core.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/core.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/editing/VisibleSelectionTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
A Source/core/testing/CoreTestHelpers.h View 1 chunk +22 lines, -0 lines 0 comments Download
A Source/core/testing/CoreTestHelpers.cpp View 1 2 1 chunk +92 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
yosin_UTC9
PTAL Resolution for build failures: - Android debug build bot: (unresolved symbol for operator<< of ...
5 years, 7 months ago (2015-04-30 00:55:25 UTC) #2
tkent
https://codereview.chromium.org/1105333002/diff/1/Source/core/core.gyp File Source/core/core.gyp (right): https://codereview.chromium.org/1105333002/diff/1/Source/core/core.gyp#newcode673 Source/core/core.gyp:673: 'wtf_unittest_helpers', Why is it defined conditionally? You need to ...
5 years, 7 months ago (2015-04-30 00:59:33 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1105333002/40001
5 years, 7 months ago (2015-05-21 04:28:35 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-21 04:31:28 UTC) #8
yosin_UTC9
PTAL - OilPan failures don't relate to this patch. - android_chromium_gn_compile_dbg should cover GN android ...
5 years, 7 months ago (2015-05-21 05:46:24 UTC) #9
tkent
lgtm https://codereview.chromium.org/1105333002/diff/40001/Source/core/testing/CoreTestHelpers.cpp File Source/core/testing/CoreTestHelpers.cpp (right): https://codereview.chromium.org/1105333002/diff/40001/Source/core/testing/CoreTestHelpers.cpp#newcode13 Source/core/testing/CoreTestHelpers.cpp:13: #include <ios> // NOLINT is "// NOLINT" necessary?
5 years, 7 months ago (2015-05-21 05:51:42 UTC) #10
yosin_UTC9
Thanks! Committing... https://codereview.chromium.org/1105333002/diff/40001/Source/core/testing/CoreTestHelpers.cpp File Source/core/testing/CoreTestHelpers.cpp (right): https://codereview.chromium.org/1105333002/diff/40001/Source/core/testing/CoreTestHelpers.cpp#newcode13 Source/core/testing/CoreTestHelpers.cpp:13: #include <ios> // NOLINT On 2015/05/21 05:51:42, ...
5 years, 7 months ago (2015-05-21 06:08:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1105333002/60001
5 years, 7 months ago (2015-05-21 06:08:49 UTC) #14
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 08:31:39 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195682

Powered by Google App Engine
This is Rietveld 408576698