Migrate Graphics2D to new design.

ppapi/proxy/ppapi_messages.h

Index: ppapi/proxy/ppapi_messages.h
diff --git a/ppapi/proxy/ppapi_messages.h b/ppapi/proxy/ppapi_messages.h
index ba99e8cee6a735e7f2e2cbf77eabdf85a9246ee6..f26cf8370349566e8183abcf61d35603928f81a4 100644
--- a/ppapi/proxy/ppapi_messages.h
+++ b/ppapi/proxy/ppapi_messages.h
@@ -900,6 +900,33 @@ IPC_MESSAGE_ROUTED2(PpapiHostMsg_PPBFileSystem_Open,
                     ppapi::HostResource /* result */,
                     int64_t /* expected_size */)
 
+// Graphics2D.
+IPC_MESSAGE_CONTROL2(PpapiHostMsg_Graphics2D_Create,
+                     PP_Size /* size */,
+                     PP_Bool /* is_always_opaque */)
+IPC_MESSAGE_ROUTED4(PpapiHostMsg_Graphics2D_PaintImageData,
+                    ppapi::HostResource /* image_data */,
+                    PP_Point /* top_left */,
+                    bool /* src_rect_specified */,
+                    PP_Rect /* src_rect */)
+IPC_MESSAGE_ROUTED3(PpapiHostMsg_Graphics2D_Scroll,
+                    bool /* clip_specified */,
+                    PP_Rect /* clip */,
+                    PP_Point /* amount */)
+IPC_MESSAGE_ROUTED1(PpapiHostMsg_Graphics2D_ReplaceContents,
+                    ppapi::HostResource /* image_data */)
+IPC_MESSAGE_ROUTED0(PpapiHostMsg_Graphics2D_Flush)

[brettw, 2012/10/05 22:38:06]

I'm trying to do a better job documenting these messages. Most of them are
pretty obvious, but for anything you think isn't obvious, and the ones where
there are a reply, we should mention the reply message (and the reply message
should mention what it is a reply to).

[victorhsieh, 2012/10/05 23:26:57]

Does it look better if we just put them next to each other like this?

+IPC_MESSAGE_ROUTED1(PpapiHostMsg_Graphics2D_Dev_SetScale,
+                    float /* scale */)
+IPC_MESSAGE_ROUTED2(PpapiHostMsg_Graphics2D_ReadImageData,
+                    PP_Resource /* image */,
+                    PP_Point /* top_left */)
+IPC_MESSAGE_CONTROL1(PpapiMsg_Graphics2D_FlushACK,
+                     int32_t /* pp_error */)

[brettw, 2012/10/05 22:38:06]

You shouldn't need this parameter. The reply params have a result code to hold
this (since almost every reply needs this).

[victorhsieh, 2012/10/05 23:26:57]

Done.

+IPC_MESSAGE_CONTROL0(PpapiMsg_Graphics2D_ReadImageDataReply)

[brettw, 2012/10/05 22:38:06]

I don't think you use this message (looks like you use Ack instead). Can you
rename Ack ACK for consistency.

[victorhsieh, 2012/10/05 23:26:57]

Done.

+IPC_MESSAGE_CONTROL0(PpapiMsg_Graphics2D_ReadImageDataAck)

[brettw, 2012/10/05 22:38:06]

I'm trying to call the reply messages "PpapiPluginMsg_..." now so can you follow
this pattern for the replies?

[victorhsieh, 2012/10/05 23:26:57]

Done.

+
+
 // PPB_Graphics2D.
 IPC_SYNC_MESSAGE_ROUTED3_1(PpapiHostMsg_PPBGraphics2D_Create,
                            PP_Instance /* instance */,