Migrate Graphics2D to new design.

ppapi/proxy/ppapi_messages.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Multiply-included message header, no traditional include guard.
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/file_path.h"
@@ skipping 417 matching lines @@
     int /* callback_id */,
     int32_t /* result */)
 
 // PPB_FileSystem.
 IPC_MESSAGE_ROUTED2(
     PpapiMsg_PPBFileSystem_OpenComplete,
     ppapi::HostResource /* filesystem */,
     int32_t /* result */)
 
 // PPB_Graphics2D.
 IPC_MESSAGE_ROUTED2(PpapiMsg_PPBGraphics2D_FlushACK,

[brettw, 2012/10/05 22:38:06]

We should be able to delete the old graphics_2d_proxy files and the other
Graphics2D messages in this header now

[victorhsieh, 2012/10/05 23:26:57]

Done.

                     ppapi::HostResource /* graphics_2d */,
                     int32_t /* pp_error */)
 
 // PPB_Graphics3D.
 IPC_MESSAGE_ROUTED2(PpapiMsg_PPBGraphics3D_SwapBuffersACK,
                     ppapi::HostResource /* graphics_3d */,
                     int32_t /* pp_error */)
 
 // PPB_ImageData.
 IPC_MESSAGE_ROUTED1(PpapiMsg_PPBImageData_NotifyUnusedImageData,
@@ skipping 444 matching lines @@
 
 // PPB_FileSystem.
 IPC_SYNC_MESSAGE_ROUTED2_1(PpapiHostMsg_PPBFileSystem_Create,
                            PP_Instance /* instance */,
                            int /* type */,
                            ppapi::HostResource /* result */)
 IPC_MESSAGE_ROUTED2(PpapiHostMsg_PPBFileSystem_Open,
                     ppapi::HostResource /* result */,
                     int64_t /* expected_size */)
 
+// Graphics2D.
+IPC_MESSAGE_CONTROL2(PpapiHostMsg_Graphics2D_Create,
+                     PP_Size /* size */,
+                     PP_Bool /* is_always_opaque */)
+IPC_MESSAGE_ROUTED4(PpapiHostMsg_Graphics2D_PaintImageData,
+                    ppapi::HostResource /* image_data */,
+                    PP_Point /* top_left */,
+                    bool /* src_rect_specified */,
+                    PP_Rect /* src_rect */)
+IPC_MESSAGE_ROUTED3(PpapiHostMsg_Graphics2D_Scroll,
+                    bool /* clip_specified */,
+                    PP_Rect /* clip */,
+                    PP_Point /* amount */)
+IPC_MESSAGE_ROUTED1(PpapiHostMsg_Graphics2D_ReplaceContents,
+                    ppapi::HostResource /* image_data */)
+IPC_MESSAGE_ROUTED0(PpapiHostMsg_Graphics2D_Flush)

[brettw, 2012/10/05 22:38:06]

I'm trying to do a better job documenting these messages. Most of them are
pretty obvious, but for anything you think isn't obvious, and the ones where
there are a reply, we should mention the reply message (and the reply message
should mention what it is a reply to).

[victorhsieh, 2012/10/05 23:26:57]

Does it look better if we just put them next to each other like this?

+IPC_MESSAGE_ROUTED1(PpapiHostMsg_Graphics2D_Dev_SetScale,
+                    float /* scale */)
+IPC_MESSAGE_ROUTED2(PpapiHostMsg_Graphics2D_ReadImageData,
+                    PP_Resource /* image */,
+                    PP_Point /* top_left */)
+IPC_MESSAGE_CONTROL1(PpapiMsg_Graphics2D_FlushACK,
+                     int32_t /* pp_error */)

[brettw, 2012/10/05 22:38:06]

You shouldn't need this parameter. The reply params have a result code to hold
this (since almost every reply needs this).

[victorhsieh, 2012/10/05 23:26:57]

Done.

+IPC_MESSAGE_CONTROL0(PpapiMsg_Graphics2D_ReadImageDataReply)

[brettw, 2012/10/05 22:38:06]

I don't think you use this message (looks like you use Ack instead). Can you
rename Ack ACK for consistency.

[victorhsieh, 2012/10/05 23:26:57]

Done.

+IPC_MESSAGE_CONTROL0(PpapiMsg_Graphics2D_ReadImageDataAck)

[brettw, 2012/10/05 22:38:06]

I'm trying to call the reply messages "PpapiPluginMsg_..." now so can you follow
this pattern for the replies?

[victorhsieh, 2012/10/05 23:26:57]

Done.

+
+
 // PPB_Graphics2D.
 IPC_SYNC_MESSAGE_ROUTED3_1(PpapiHostMsg_PPBGraphics2D_Create,
                            PP_Instance /* instance */,
                            PP_Size /* size */,
                            PP_Bool /* is_always_opaque */,
                            ppapi::HostResource /* result */)
 IPC_MESSAGE_ROUTED5(PpapiHostMsg_PPBGraphics2D_PaintImageData,
                     ppapi::HostResource /* graphics_2d */,
                     ppapi::HostResource /* image_data */,
                     PP_Point /* top_left */,
@@ skipping 658 matching lines @@
 
 // Reply to a RequestMemory call. This supplies the shared memory handle. The
 // actual handle is passed in the ReplyParams struct.
 IPC_MESSAGE_CONTROL0(PpapiPluginMsg_Gamepad_SendMemory)
 
 // Printing.
 IPC_MESSAGE_CONTROL0(PpapiHostMsg_Printing_Create)
 IPC_MESSAGE_CONTROL0(PpapiHostMsg_Printing_GetDefaultPrintSettings)
 IPC_MESSAGE_CONTROL1(PpapiPluginMsg_Printing_GetDefaultPrintSettingsReply,
                      PP_PrintSettings_Dev /* print_settings */)