Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 1105293003: android_webview: don't suppress debuggerd crash handling. (Closed)

Created:
5 years, 7 months ago by Torne
Modified:
5 years, 7 months ago
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

android_webview: don't suppress debuggerd crash handling. WebView was incorrectly suppressing debuggerd crash handling after breakpad microdumps were triggered on all user builds of android, as the process type was not empty as expected for the Chrome browser process. This went unnoticed as the normal behaviour was still in place for userdebug/eng builds. Fix by also treating "webview" process type as a browser process in the crash component. BUG=481420 Committed: https://crrev.com/5db4beded0f78f77207790cd9a66bf7fcbfc4fc3 Cr-Commit-Position: refs/heads/master@{#327277}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M components/crash/app/breakpad_linux.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Torne
+primiano as we discussed this offline +jochen for OWNERS This is a P0 bug, please ...
5 years, 7 months ago (2015-04-28 12:15:50 UTC) #2
Torne
Tested on a user device and verified that we no longer suppress the crash dialog ...
5 years, 7 months ago (2015-04-28 12:16:41 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 7 months ago (2015-04-28 12:21:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1105293003/1
5 years, 7 months ago (2015-04-28 12:49:35 UTC) #6
Primiano Tucci (use gerrit)
LGTM.
5 years, 7 months ago (2015-04-28 12:50:38 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-28 13:05:30 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 13:46:19 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5db4beded0f78f77207790cd9a66bf7fcbfc4fc3
Cr-Commit-Position: refs/heads/master@{#327277}

Powered by Google App Engine
This is Rietveld 408576698