Issue 465302:System wide share options on Mac

chrome/browser/ui/cocoa/renderer_context_menu/share_menu_controller.h

Index: chrome/browser/ui/cocoa/renderer_context_menu/share_menu_controller.h
diff --git a/chrome/browser/ui/cocoa/renderer_context_menu/share_menu_controller.h b/chrome/browser/ui/cocoa/renderer_context_menu/share_menu_controller.h
new file mode 100644
index 0000000000000000000000000000000000000000..94cd4e164ac732229b4ef92b8b63d86b5c3f657f
--- /dev/null
+++ b/chrome/browser/ui/cocoa/renderer_context_menu/share_menu_controller.h
@@ -0,0 +1,32 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.

[shrike, 2015/05/05 18:20:22]

Should by copyright 2015.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+

[shrike, 2015/05/05 18:20:22]

What's the reason for putting this new class in
chrome/browser/ui/cocoa/renderer_context_menu? Seems like it should live in
chrome/browser/ui/cocoa/.

+#ifndef CHROME_BROWSER_UI_COCOA_RENDERER_CONTEXT_SHARE_MENU_CONTROLLER
+#define CHROME_BROWSER_UI_COCOA_RENDERER_CONTEXT_SHARE_MENU_CONTROLLER
+
+#import <Cocoa/Cocoa.h>
+
+#include "base/memory/scoped_ptr.h"
+

[shrike, 2015/05/05 18:20:22]

Should be one space after namespace.

+namespace  ShareMenuControllerInternal {
+    class Observer;
+}
+
+@interface ShareMenuController : NSObject {
+ @private
+  __weak NSMenu* mainMenu_;

[shrike, 2015/05/05 18:20:22]

All of these lines should be indented 2 spaces?

+    scoped_ptr<ShareMenuControllerInternal::Observer> observer_;
+    NSMutableArray* shareItems_;
+    NSMenuItem* fileMeuItem_;

[Avi (use Gerrit), 2015/05/05 18:47:50]

typo: Menu, not Meu

+    NSMenuItem* shareMenuItem_;
+    NSMenu* shareSubMenu_;
+    BOOL menuItemsLoaded_;
+}
+

[shrike, 2015/05/05 18:20:23]

No space between (id) and initWithMainMenu (same issue with menuItemsLoaded).

+- (id) initWithMainMenu:(NSMenu* )menu;
+- (BOOL) menuItemsLoaded;
+
+@end
+

[shrike, 2015/05/05 18:20:22]

Two spaces between #endif and //, followed by 1 space.

+#endif //  CHROME_BROWSER_UI_COCOA_RENDERER_CONTEXT_SHARE_MENU_CONTROLLER