chrome/browser/ui/cocoa/renderer_context_menu/share_menu_controller.h - Issue 1105143005: Issue 465302:System wide share options on Mac

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/cocoa/renderer_context_menu/share_menu_controller.h

Issue 1105143005: Issue 465302:System wide share options on Mac Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: System wide share menu for Mac Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/app_controller_mac.mm ('K') | « chrome/browser/app_controller_mac.mm ('k') | chrome/browser/ui/cocoa/renderer_context_menu/share_menu_controller.mm » ('j') | chrome/browser/ui/cocoa/renderer_context_menu/share_menu_controller.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.
	shrike 2015/05/05 18:20:22 Should by copyright 2015. Should by copyright 2015.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4
	shrike 2015/05/05 18:20:22 What's the reason for putting this new class in ch What's the reason for putting this new class in chrome/browser/ui/cocoa/renderer_context_menu? Seems like it should live in chrome/browser/ui/cocoa/.
	5 #ifndef CHROME_BROWSER_UI_COCOA_RENDERER_CONTEXT_SHARE_MENU_CONTROLLER

	6 #define CHROME_BROWSER_UI_COCOA_RENDERER_CONTEXT_SHARE_MENU_CONTROLLER

	7

	8 #import <Cocoa/Cocoa.h>

	9

	10 #include "base/memory/scoped_ptr.h"

	11
	shrike 2015/05/05 18:20:22 Should be one space after namespace. Should be one space after namespace.
	12 namespace ShareMenuControllerInternal {

	13 class Observer;

	14 }

	15

	16 @interface ShareMenuController : NSObject {

	17 @private

	18 __weak NSMenu* mainMenu_;
	shrike 2015/05/05 18:20:22 All of these lines should be indented 2 spaces? All of these lines should be indented 2 spaces?
	19 scoped_ptr<ShareMenuControllerInternal::Observer> observer_;

	20 NSMutableArray* shareItems_;

	21 NSMenuItem* fileMeuItem_;
	Avi (use Gerrit) 2015/05/05 18:47:50 typo: Menu, not Meu typo: Menu, not Meu
	22 NSMenuItem* shareMenuItem_;

	23 NSMenu* shareSubMenu_;

	24 BOOL menuItemsLoaded_;

	25 }

	26
	shrike 2015/05/05 18:20:23 No space between (id) and initWithMainMenu (same i No space between (id) and initWithMainMenu (same issue with menuItemsLoaded).
	27 - (id) initWithMainMenu:(NSMenu* )menu;

	28 - (BOOL) menuItemsLoaded;

	29

	30 @end

	31
	shrike 2015/05/05 18:20:22 Two spaces between #endif and //, followed by 1 sp Two spaces between #endif and //, followed by 1 space.
	32 #endif // CHROME_BROWSER_UI_COCOA_RENDERER_CONTEXT_SHARE_MENU_CONTROLLER

OLD	NEW