Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1105103003: Update renderer in core/css. (Closed)

Created:
5 years, 8 months ago by dsinclair
Modified:
5 years, 8 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Update renderer in core/css. This CL updates the various uses of renderer to layoutObject in the core/css directory. BUG=462960 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194548

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -174 lines) Patch
M Source/core/css/CSSCanvasValue.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 5 chunks +20 lines, -16 lines 0 comments Download
M Source/core/css/CSSCrossfadeValue.cpp View 4 chunks +14 lines, -14 lines 0 comments Download
M Source/core/css/CSSDefaultStyleSheets.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSGradientValue.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/core/css/CSSImageGeneratorValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSImageGeneratorValue.cpp View 7 chunks +26 lines, -26 lines 0 comments Download
M Source/core/css/CSSImageValue.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSToLengthConversionData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/ComputedStyleCSSValueMapping.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/ComputedStyleCSSValueMapping.cpp View 27 chunks +88 lines, -88 lines 0 comments Download
M Source/core/css/invalidation/StyleInvalidator.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleAdjuster.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 5 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
dsinclair
PTAL.
5 years, 8 months ago (2015-04-27 14:49:20 UTC) #2
leviw_travelin_and_unemployed
lgtm https://codereview.chromium.org/1105103003/diff/1/Source/core/css/CSSComputedStyleDeclaration.cpp File Source/core/css/CSSComputedStyleDeclaration.cpp (right): https://codereview.chromium.org/1105103003/diff/1/Source/core/css/CSSComputedStyleDeclaration.cpp#newcode475 Source/core/css/CSSComputedStyleDeclaration.cpp:475: return layoutObject && layoutObject->isBox() && (!style || !style->marginBottom().isFixed() ...
5 years, 8 months ago (2015-04-27 18:27:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1105103003/1
5 years, 8 months ago (2015-04-27 18:27:21 UTC) #5
leviw_travelin_and_unemployed
On 2015/04/27 at 18:29:44, leviw wrote: > The CQ bit was unchecked by leviw@chromium.org Oops, ...
5 years, 8 months ago (2015-04-27 18:30:04 UTC) #7
dsinclair
https://codereview.chromium.org/1105103003/diff/1/Source/core/css/CSSComputedStyleDeclaration.cpp File Source/core/css/CSSComputedStyleDeclaration.cpp (right): https://codereview.chromium.org/1105103003/diff/1/Source/core/css/CSSComputedStyleDeclaration.cpp#newcode475 Source/core/css/CSSComputedStyleDeclaration.cpp:475: return layoutObject && layoutObject->isBox() && (!style || !style->marginBottom().isFixed() || ...
5 years, 8 months ago (2015-04-27 19:10:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1105103003/20001
5 years, 8 months ago (2015-04-27 19:11:10 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 20:42:44 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194548

Powered by Google App Engine
This is Rietveld 408576698