Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 1105093002: Cleanup return values in http_auth (Closed)

Created:
5 years, 8 months ago by payal.pandey
Modified:
5 years, 7 months ago
Reviewers:
d.samantaray, eroman, gavinp
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup return values in http_auth This CL turns const by value return values into const by ref BUG=393155 Committed: https://crrev.com/8a0c2c45a7d9c729ca378d1791e9a88ff38f31d1 Cr-Commit-Position: refs/heads/master@{#327239}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M net/http/http_auth_cache.h View 2 chunks +2 lines, -6 lines 0 comments Download
M net/http/http_auth_handler.h View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
payal.pandey
Please have a look, Thanks.
5 years, 8 months ago (2015-04-27 12:56:31 UTC) #2
eroman
lgtm
5 years, 7 months ago (2015-04-27 21:23:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1105093002/1
5 years, 7 months ago (2015-04-28 04:43:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-28 06:36:06 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8a0c2c45a7d9c729ca378d1791e9a88ff38f31d1 Cr-Commit-Position: refs/heads/master@{#327239}
5 years, 7 months ago (2015-04-28 06:36:53 UTC) #7
d.samantaray
5 years, 7 months ago (2015-04-28 12:24:59 UTC) #9
Message was sent while issue was closed.
I have uploaded the patch.
 https://codereview.chromium.org/1113493004

Please review

Powered by Google App Engine
This is Rietveld 408576698