Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 1113493004: Cleanup return values in autofill_sync (Closed)

Created:
5 years, 7 months ago by vaibhav1.a
Modified:
5 years, 6 months ago
Reviewers:
eroman
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup return values in autofill_sync This CL turns const by value return values into const by ref BUG=393155

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M chrome/browser/sync/test/integration/performance/autofill_sync_perf_test.cc View 3 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
eroman
not lgtm it is not valid to return a reference to a local variable.
5 years, 7 months ago (2015-04-28 19:00:48 UTC) #2
lgombos
5 years, 6 months ago (2015-06-18 04:07:03 UTC) #3
Closing.

Powered by Google App Engine
This is Rietveld 408576698