Switch audio hang monitor to default-off. Enable for non-beta,stable.

Switch audio hang monitor to default-off. Enable for non-beta,stable.

Too many crashes and out of ideas for how to resolve this for right
now; this at least provides the chance that these users might unhang
themselves some time after the 2 minute hang timer.

BUG=422522, 468074, 478932
TEST=start w/ and w/o hang monitor according to channel, flags.

Committed: https://crrev.com/1620bd3aa0fff0878430ef63fcd69461cadf69f7
Cr-Commit-Position: refs/heads/master@{#327356}

[DaleCurtis, 2015-04-28 16:28:30]

dalecurtis@chromium.org changed reviewers:
+ thakis@chromium.org

[DaleCurtis, 2015-04-28 16:28:31]

TPMs are onboard with this plan per laforge@.

Nico, I couldn't find a more specific reviewer, so please feel free to point me
elsewhere if it's not you :)

[Nico, 2015-04-28 16:59:04]

On 2015/04/28 16:28:31, DaleCurtis wrote:
> TPMs are onboard with this plan per laforge@.
> 
> Nico, I couldn't find a more specific reviewer, so please feel free to point
me
> elsewhere if it's not you :)

If you have enough stacks, why keep this on on dev?

[DaleCurtis, 2015-04-28 17:14:16]

I wouldn't say we have enough stacks. I choose dev because that means we can see
linux, cros, etc which don't have canary. Limiting it to canary might not get
enough feedback.

We still need this to occur loud enough for a savvy user to file a bug and
perhaps get us a dump of the svchost.exe process to provide to microsoft for
analysis.

Other platforms shouldn't be hanging, so I still want coverage there too.

[Nico, 2015-04-28 17:53:38]

lgtm either way

https://codereview.chromium.org/1105083004/diff/1/chrome/browser/chrome_brows...
File chrome/browser/chrome_browser_main.cc (right):

https://codereview.chromium.org/1105083004/diff/1/chrome/browser/chrome_brows...
chrome/browser/chrome_browser_main.cc:674: // track down the root causes of
crbug.com/422522 and crbug.com/478932.
do you want to do this only on windows then?

[DaleCurtis, 2015-04-28 18:27:09]

Thanks for review!

https://codereview.chromium.org/1105083004/diff/1/chrome/browser/chrome_brows...
File chrome/browser/chrome_browser_main.cc (right):

https://codereview.chromium.org/1105083004/diff/1/chrome/browser/chrome_brows...
chrome/browser/chrome_browser_main.cc:674: // track down the root causes of
crbug.com/422522 and crbug.com/478932.
On 2015/04/28 17:53:38, Nico wrote:
> do you want to do this only on windows then?

Not yet, I'd like more confidence given the lower user counts on dev, beta for
other platforms. We already had one googler bug pointing to a broken pulseaudio
install.

[DaleCurtis, 2015-04-28 18:27:27]

https://codereview.chromium.org/1105083004/diff/1/chrome/browser/chrome_brows...
File chrome/browser/chrome_browser_main.cc (right):

https://codereview.chromium.org/1105083004/diff/1/chrome/browser/chrome_brows...
chrome/browser/chrome_browser_main.cc:674: // track down the root causes of
crbug.com/422522 and crbug.com/478932.
On 2015/04/28 18:27:09, DaleCurtis wrote:
> On 2015/04/28 17:53:38, Nico wrote:
> > do you want to do this only on windows then?
> 
> Not yet, I'd like more confidence given the lower user counts on dev, beta for
> other platforms. We already had one googler bug pointing to a broken
pulseaudio
> install.

Err lower user counts on dev, not beta.

[DaleCurtis, 2015-04-28 18:27:33]

The CQ bit was checked by dalecurtis@chromium.org

[commit-bot: I haz the power, 2015-04-28 18:28:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1105083004/1

[commit-bot: I haz the power, 2015-04-28 18:31:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-28 18:31:35]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[DaleCurtis, 2015-04-28 19:16:30]

The CQ bit was checked by dalecurtis@chromium.org

[DaleCurtis, 2015-04-28 19:16:30]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1105083004/#ps20001
(title: "Rebase.")

[commit-bot: I haz the power, 2015-04-28 19:17:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1105083004/20001

[commit-bot: I haz the power, 2015-04-28 20:26:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-28 20:28:15]

Patchset 2 (id:??) landed as
https://crrev.com/1620bd3aa0fff0878430ef63fcd69461cadf69f7
Cr-Commit-Position: refs/heads/master@{#327356}

[brucedawson, 2015-04-29 20:46:28]

The version checks before the call to EnableHangMonitor() appear to be wrong.
This was picked up by the /analyze fyi builder. I filed bug
https://code.google.com/p/chromium/issues/detail?id=482674 to track this.