Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 110503004: ES6 Promise: Rename method names to match spec. (Closed)

Created:
7 years ago by arv (Not doing code reviews)
Modified:
7 years ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

ES6 Promise: Rename method names to match spec. https://github.com/domenic/promises-unwrapping/blob/master/README.md Promise.resolved -> Promise.resolve Promise.rejected -> Promise.reject Promise.one -> Promise.race This does not remove the non standard functions chain nor deferred. BUG=v8:3050

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -143 lines) Patch
M src/promise.js View 5 chunks +7 lines, -7 lines 0 comments Download
M test/mjsunit/harmony/promises.js View 25 chunks +136 lines, -136 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
arv (Not doing code reviews)
I'm not sure why we ended up with different names for these functions. This is ...
7 years ago (2013-12-09 21:57:28 UTC) #1
rossberg
On 2013/12/09 21:57:28, arv wrote: > I'm not sure why we ended up with different ...
7 years ago (2013-12-10 10:14:46 UTC) #2
arv (Not doing code reviews)
7 years ago (2013-12-10 14:21:54 UTC) #3
On 2013/12/10 10:14:46, rossberg wrote:
> On 2013/12/09 21:57:28, arv wrote:
> > I'm not sure why we ended up with different names for these functions. This
is
> a
> > trivial change and it makes us pass more tests.
> 
> Thanks, but there's already a CL in flight including those changes (couldn't
> land it yet since the tree was closed due to the imminent M33 branch):
> 
> https://codereview.chromium.org/99573002/

Thanks, I only searched the bugs db. Next time I'll search the code review site
too.

Powered by Google App Engine
This is Rietveld 408576698