tools/release/releases.py - Issue 1105023002: [release-tools] Return no hash if version is not available.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/release/releases.py

Issue 1105023002: [release-tools] Return no hash if version is not available. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/release/releases.py

diff --git a/tools/release/releases.py b/tools/release/releases.py

index a82da2bddf5aaec98fc9518180fc47297093f9d2..5b826fccba089d27afc2f0cab0fefc209ae033af 100755

--- a/tools/release/releases.py

+++ b/tools/release/releases.py

@@ -461,6 +461,8 @@ class RetrieveInformationOnChromeReleases(Step):

self["chrome_releases"] = chrome_releases

def _GetGitHashForV8Version(self, v8_version):

+ if v8_version == "N/A":

+ return ""

if v8_version.split(".")[3]== "0":

return self.GitGetHashOfTag(v8_version[:-2])

« no previous file with comments | « no previous file | no next file » | no next file with comments »