Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1157)

Side by Side Diff: tools/release/releases.py

Issue 1105023002: [release-tools] Return no hash if version is not available. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright 2014 the V8 project authors. All rights reserved. 2 # Copyright 2014 the V8 project authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 # This script retrieves the history of all V8 branches and 6 # This script retrieves the history of all V8 branches and
7 # their corresponding Chromium revisions. 7 # their corresponding Chromium revisions.
8 8
9 # Requires a chromium checkout with branch heads: 9 # Requires a chromium checkout with branch heads:
10 # gclient sync --with_branch_heads 10 # gclient sync --with_branch_heads
(...skipping 443 matching lines...) Expand 10 before | Expand all | Expand 10 after
454 if current_version["channel"] != "canary": 454 if current_version["channel"] != "canary":
455 continue 455 continue
456 456
457 current_candidate = self._CreateCandidate(current_version) 457 current_candidate = self._CreateCandidate(current_version)
458 canaries.append(current_candidate) 458 canaries.append(current_candidate)
459 459
460 chrome_releases = {"canaries": canaries} 460 chrome_releases = {"canaries": canaries}
461 self["chrome_releases"] = chrome_releases 461 self["chrome_releases"] = chrome_releases
462 462
463 def _GetGitHashForV8Version(self, v8_version): 463 def _GetGitHashForV8Version(self, v8_version):
464 if v8_version == "N/A":
465 return ""
464 if v8_version.split(".")[3]== "0": 466 if v8_version.split(".")[3]== "0":
465 return self.GitGetHashOfTag(v8_version[:-2]) 467 return self.GitGetHashOfTag(v8_version[:-2])
466 468
467 return self.GitGetHashOfTag(v8_version) 469 return self.GitGetHashOfTag(v8_version)
468 470
469 def _CreateCandidate(self, current_version): 471 def _CreateCandidate(self, current_version):
470 params = None 472 params = None
471 url_to_call = (OMAHA_PROXY_URL + "v8.json?version=" 473 url_to_call = (OMAHA_PROXY_URL + "v8.json?version="
472 + current_version["previous_version"]) 474 + current_version["previous_version"])
473 result_raw = self.ReadURL( 475 result_raw = self.ReadURL(
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
560 RetrieveChromiumV8Releases, 562 RetrieveChromiumV8Releases,
561 RetrieveChromiumBranches, 563 RetrieveChromiumBranches,
562 RetrieveInformationOnChromeReleases, 564 RetrieveInformationOnChromeReleases,
563 CleanUp, 565 CleanUp,
564 WriteOutput, 566 WriteOutput,
565 ] 567 ]
566 568
567 569
568 if __name__ == "__main__": # pragma: no cover 570 if __name__ == "__main__": # pragma: no cover
569 sys.exit(Releases().Run()) 571 sys.exit(Releases().Run())
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698