Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Issue 1105023002: [release-tools] Return no hash if version is not available. (Closed)

Created:
5 years, 7 months ago by Michael Hablich
Modified:
5 years, 7 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[release-tools] Return no hash if version is not available. BUG= Committed: https://crrev.com/8d8b742b9d08a3cdc920af7563b9b96d16ba3c12 Cr-Commit-Position: refs/heads/master@{#28070}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/release/releases.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Michael Hablich
PTAL
5 years, 7 months ago (2015-04-27 09:53:07 UTC) #2
Michael Achenbach
lgtm
5 years, 7 months ago (2015-04-27 11:09:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1105023002/1
5 years, 7 months ago (2015-04-27 11:09:54 UTC) #5
Michael Achenbach
FYI: I added the [release-tools] prefix in the message.
5 years, 7 months ago (2015-04-27 11:10:07 UTC) #6
Michael Achenbach
In general you should also add NOTRY=true to all release tools CLs to not spam ...
5 years, 7 months ago (2015-04-27 11:10:42 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-27 11:32:32 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-04-27 11:32:48 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8d8b742b9d08a3cdc920af7563b9b96d16ba3c12
Cr-Commit-Position: refs/heads/master@{#28070}

Powered by Google App Engine
This is Rietveld 408576698