Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 1104713003: Fix a regression with cut off images. (Closed)

Created:
5 years, 8 months ago by Lei Zhang
Modified:
5 years, 8 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@2357
Target Ref:
refs/heads/chromium/2357
Visibility:
Public.

Description

Fix a regression with cut off images. This regressed in commit 3f41851 due to shadow variables. BUG=478164 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1101443004 (cherry picked from commit 97d10aff654e42c1b7c3d2abf33fbcf8d341799e) Committed: https://pdfium.googlesource.com/pdfium/+/c619ea6d1222965349c2d35ef2fd09fa851fab49

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lei Zhang
I did not merge the DEPS portion of the original CL.
5 years, 8 months ago (2015-04-23 20:20:08 UTC) #1
Lei Zhang
5 years, 8 months ago (2015-04-23 20:20:19 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c619ea6d1222965349c2d35ef2fd09fa851fab49 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698