Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 1104543004: Update {virtual,override} to follow C++11 style in extensions. (Closed)

Created:
5 years, 8 months ago by ncarter (slow)
Modified:
5 years, 8 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override} to follow C++11 style in extensions. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was manually generated using a regex and a text editor. BUG=417463 Committed: https://crrev.com/0ec9f9fbbc048a0a05b74cad9c6ee795f89bb641 Cr-Commit-Position: refs/heads/master@{#326545}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -35 lines) Patch
M extensions/browser/api/socket/socket_api.h View 2 chunks +9 lines, -11 lines 0 comments Download
M extensions/browser/api/usb/usb_apitest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M extensions/browser/browser_context_keyed_api_factory.h View 3 chunks +4 lines, -4 lines 0 comments Download
M extensions/browser/mock_extension_system.h View 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/common/permissions/set_disjunction_permission.h View 8 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ncarter (slow)
5 years, 8 months ago (2015-04-23 02:11:07 UTC) #2
Devlin
lgtm
5 years, 8 months ago (2015-04-23 15:28:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104543004/1
5 years, 8 months ago (2015-04-23 16:38:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-23 16:43:23 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 16:44:24 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ec9f9fbbc048a0a05b74cad9c6ee795f89bb641
Cr-Commit-Position: refs/heads/master@{#326545}

Powered by Google App Engine
This is Rietveld 408576698