Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: extensions/browser/api/socket/socket_api.h

Issue 1104543004: Update {virtual,override} to follow C++11 style in extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/browser/api/usb/usb_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/socket/socket_api.h
diff --git a/extensions/browser/api/socket/socket_api.h b/extensions/browser/api/socket/socket_api.h
index a3e4e0ead7872f5f4a7cdf7c22ec19c06e96fc36..d6e473678b9aac230911d10d17a25da76d2da9fb 100644
--- a/extensions/browser/api/socket/socket_api.h
+++ b/extensions/browser/api/socket/socket_api.h
@@ -62,7 +62,7 @@ class SocketResourceManager : public SocketResourceManagerInterface {
public:
SocketResourceManager() : manager_(NULL) {}
- virtual bool SetBrowserContext(content::BrowserContext* context) override {
+ bool SetBrowserContext(content::BrowserContext* context) override {
manager_ = ApiResourceManager<T>::Get(context);
DCHECK(manager_)
<< "There is no socket manager. "
@@ -72,29 +72,27 @@ class SocketResourceManager : public SocketResourceManagerInterface {
return manager_ != NULL;
}
- virtual int Add(Socket* socket) override {
+ int Add(Socket* socket) override {
// Note: Cast needed here, because "T" may be a subclass of "Socket".
return manager_->Add(static_cast<T*>(socket));
}
- virtual Socket* Get(const std::string& extension_id,
- int api_resource_id) override {
+ Socket* Get(const std::string& extension_id, int api_resource_id) override {
return manager_->Get(extension_id, api_resource_id);
}
- virtual void Replace(const std::string& extension_id,
- int api_resource_id,
- Socket* socket) override {
+ void Replace(const std::string& extension_id,
+ int api_resource_id,
+ Socket* socket) override {
manager_->Replace(extension_id, api_resource_id, static_cast<T*>(socket));
}
- virtual void Remove(const std::string& extension_id,
- int api_resource_id) override {
+ void Remove(const std::string& extension_id, int api_resource_id) override {
manager_->Remove(extension_id, api_resource_id);
}
- virtual base::hash_set<int>* GetResourceIds(const std::string& extension_id)
- override {
+ base::hash_set<int>* GetResourceIds(
+ const std::string& extension_id) override {
return manager_->GetResourceIds(extension_id);
}
« no previous file with comments | « no previous file | extensions/browser/api/usb/usb_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698